remove blur on shelf when maximized |
||||||||
Issue descriptionThis also prevents android app from using overlay under certain condition.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2 commit 1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Oct 26 00:15:13 2018 Don't use blur when maximized Also use NOT_DRAWN layer for shelf because it has no real content. All child views have its own layers. This also chagnes the opacity to 100% per discussion with sgabriel@ Bug: 899079 Test: manual. No Change-Id: I6ea82784e49e929902a7a7d00fc934d9c8033045 Reviewed-on: https://chromium-review.googlesource.com/c/1300108 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#602942} [modify] https://crrev.com/1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2/ash/shelf/shelf_constants.h [modify] https://crrev.com/1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2/ash/shelf/shelf_widget.cc
,
Oct 30
CL landed in 72.0.3592.0, and I tested on latest canary(72.0.3593.0).
,
Oct 31
,
Oct 31
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
Approving merge to M71 Chrome OS. Thanks for the verification in #4.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcf5e3f36f388876012b8aa28ebefbea906ca1f commit 9dcf5e3f36f388876012b8aa28ebefbea906ca1f Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Nov 01 21:22:32 2018 Don't use blur when maximized Also use NOT_DRAWN layer for shelf because it has no real content. All child views have its own layers. This also chagnes the opacity to 100% per discussion with sgabriel@ Bug: 899079 Test: manual. No visual change Change-Id: I6ea82784e49e929902a7a7d00fc934d9c8033045 Reviewed-on: https://chromium-review.googlesource.com/c/1300108 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602942}(cherry picked from commit 1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2) Reviewed-on: https://chromium-review.googlesource.com/c/1313559 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#462} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9dcf5e3f36f388876012b8aa28ebefbea906ca1f/ash/shelf/shelf_constants.h [modify] https://crrev.com/9dcf5e3f36f388876012b8aa28ebefbea906ca1f/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/9dcf5e3f36f388876012b8aa28ebefbea906ca1f/ash/shelf/shelf_widget.cc
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcf5e3f36f388876012b8aa28ebefbea906ca1f Commit: 9dcf5e3f36f388876012b8aa28ebefbea906ca1f Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-01 21:22:32 +0000 UTC Don't use blur when maximized Also use NOT_DRAWN layer for shelf because it has no real content. All child views have its own layers. This also chagnes the opacity to 100% per discussion with sgabriel@ Bug: 899079 Test: manual. No visual change Change-Id: I6ea82784e49e929902a7a7d00fc934d9c8033045 Reviewed-on: https://chromium-review.googlesource.com/c/1300108 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602942}(cherry picked from commit 1db9d20fdbc11fdb2f6f83c6f5fb2d02e34fb9a2) Reviewed-on: https://chromium-review.googlesource.com/c/1313559 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#462} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by osh...@chromium.org
, Oct 25