gcp_installer.exe should use chrome version_info resource |
||
Issue descriptiongcp_installer.exe currently uses the 7-zip version_info resource because it is based on the 7-zip self extracting module. This should be updated to use the a version_info that is specific to the credential provider.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130 commit e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130 Author: Roger Tawa <rogerta@chromium.org> Date: Fri Oct 26 14:46:22 2018 Fix the gcp_installer.exe version_info. Bug: 899077 Change-Id: I5247aee260df04a450b485b6b55d25c2ae1fc2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1300107 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603086} [modify] https://crrev.com/e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130/chrome/credential_provider/BUILD.gn [modify] https://crrev.com/e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130/chrome/credential_provider/build/make_setup.py [modify] https://crrev.com/e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130/chrome/credential_provider/setup/BUILD.gn [modify] https://crrev.com/e3f5a0dd5fca2a1503be2acc5c1fb0e0d5eb9130/third_party/lzma_sdk/Util/SfxSetup/BUILD.gn
,
Oct 26
|
||
►
Sign in to add a comment |
||
Comment 1 by rogerta@chromium.org
, Oct 25