New issue
Advanced search Search tips

Issue 899074 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

SVG: Geometry properties should not accept unitless lengths

Project Member Reported by ericwilligers@chromium.org, Oct 25

Issue description

We should have an Intent to Deprecate and Remove for CSS properties
cx cy r rx ry x y
accepting numbers. Attributes won't be affected.
https://svgwg.org/svg2-draft/single-page.html#types-syntax

CSSWG discussion
https://github.com/w3c/csswg-drafts/issues/3057

Use counts for <number>:
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/cx/ 0.002%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/cy/ 0.002%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/r/ 0.004%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/rx/ 0.001%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/ry/ 0.001%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/x/ 0.001%
https://developer.microsoft.com/en-us/microsoft-edge/platform/usage/css/y/ 0.001%

We should add one or more Blink use counts to confirm that removal is safe.

We should also have distinct use counts for unitless numbers in
stroke-width and stroke-dasharray and baseline-shift properties.
Again, attributes would not be counted.

 
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)
Owner: f...@opera.com
Status: Assigned (was: Available)
I can add a use counter.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c89aaef8c1cda301eec6d5b8330adde770a56be

commit 6c89aaef8c1cda301eec6d5b8330adde770a56be
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Oct 29 11:18:22 2018

Add use counter for SVG geometry properties unitless values

Add the kSVGGeometryPropertyHasNonZeroUnitlessValue use counter for
non-zero unitless (<number> / "user units") values in the 'x', 'y', 'r',
'rx', 'ry', 'cx' and 'cy' properties.

Bug: 899074
Change-Id: I1a7e6cdce018a75ed46745ec245dabcaed5ea954
Reviewed-on: https://chromium-review.googlesource.com/c/1301597
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#603454}
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.h
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/parser/css_property_parser_test.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/cx_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/cy_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/r_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/rx_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/ry_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/x_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/third_party/blink/renderer/core/css/properties/longhands/y_custom.cc
[modify] https://crrev.com/6c89aaef8c1cda301eec6d5b8330adde770a56be/tools/metrics/histograms/enums.xml

Owner: ----
Status: Available (was: Assigned)
Just took a look at the use counter[1], and I can't say it's looking too good for this change. Almost makes me wonder if I messed something up even =P.

[1] https://www.chromestatus.com/metrics/feature/timeline/popularity/2613

Sign in to add a comment