New issue
Advanced search Search tips

Issue 899072 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Picture-in-Picture background always black

Project Member Reported by lethalantidote@chromium.org, Oct 25

Issue description

When one PiPs a transparent video, the background is black regardless of the color of the originating site's background. Ideally, I believe these should match instead.

To repro this, PiP the MediaStream video here. The background of the site is white, but when PiPed, the PiP background is black.
https://beaufortfrancois.github.io/sandbox/media/picture-in-picture-playground


The reason why the background is always black is because of this line
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/overlay/overlay_window_views.cc?rcl=4667a219b729a7e3cb1dc6b31d3f5ca024715dd9&l=269



 
What if web page background color changes, shall we update PiP window as well?
FWIW, I think this is not an easy change.
We could default to making it transparent if the video is transparent? 
Status: WontFix (was: Available)
I think a black background is the right thing to do for Picture-in-Picture. The use case of transparent videos in Picture-in-Picture is rare enough and handling this correctly would be very complex.

Sign in to add a comment