This bug tracks work done on the credit card expiration date fix flow / missing information flow.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1be9c2682be20eae03ccde68d25344a06195c355 commit 1be9c2682be20eae03ccde68d25344a06195c355 Author: Hao Zhang <hozhng@google.com> Date: Sat Nov 03 00:23:51 2018 [Autofill] create editableExpirationDate flag and determine when to request expiration date correctly Change-Id: I231263dece7fbb2a1a0eefdebb30a29c48e27d6b Bug: 899057 Reviewed-on: https://chromium-review.googlesource.com/c/1297696 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#605107} [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/chrome/browser/about_flags.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/form_data_importer.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/form_data_importer.h [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/browser/form_data_importer_unittest.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/components/autofill/core/common/autofill_features.h [modify] https://crrev.com/1be9c2682be20eae03ccde68d25344a06195c355/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eb0082a1d088999db2d83dc8d16c8548e3bdb58 commit 1eb0082a1d088999db2d83dc8d16c8548e3bdb58 Author: Hao Zhang <hozhng@google.com> Date: Wed Nov 07 01:11:33 2018 [Autofill] create UI that asks for expiration date Change-Id: I764f1cccc3dbf40e2580bc3bdf89bc789422a8d1 Bug: 899057 Reviewed-on: https://chromium-review.googlesource.com/c/1300314 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#605911} [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/android_webview/browser/aw_autofill_client.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/views/autofill/save_card_bubble_views.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/form_data_importer.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/components/autofill/core/browser/ui/save_card_bubble_controller.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/ios/web_view/internal/autofill/web_view_autofill_client_ios.h [modify] https://crrev.com/1eb0082a1d088999db2d83dc8d16c8548e3bdb58/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91ac7d1293add420d9531cf908c8a039ece95c3e commit 91ac7d1293add420d9531cf908c8a039ece95c3e Author: Hao Zhang <hozhng@google.com> Date: Wed Nov 07 02:44:14 2018 [Autofill] add metrics for missing expiration date Bug: 899057 Change-Id: I622240f7ca81f2d6227f15121509aca66256a68c Reviewed-on: https://chromium-review.googlesource.com/c/1309298 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#605937} [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/91ac7d1293add420d9531cf908c8a039ece95c3e/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b32c1d4e2cb7569383651c02ec237792597f203 commit 6b32c1d4e2cb7569383651c02ec237792597f203 Author: Hao Zhang <hozhng@google.com> Date: Tue Nov 13 01:46:10 2018 [Exp date fix flow] Remove duplicate lines causing incorrect logic These lines should be imported which caused a bug. https://chromium-review.googlesource.com/c/chromium/src/+/1300314/39/components/autofill/core/browser/form_data_importer.cc The line 445 to 449 should be removed and the line 451 to 455 is the right place. They shouldn't be kept both from this patch. https://chromium-review.googlesource.com/c/chromium/src/+/1300314/18 It will auto-reject offering upload of expiration date fix flow cards as long as you have 1+ server cards on the device. Bug: 899057 Change-Id: I55504fce3fe67ef57ad772c73e5026e793d3f033 Reviewed-on: https://chromium-review.googlesource.com/c/1329847 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607421} [modify] https://crrev.com/6b32c1d4e2cb7569383651c02ec237792597f203/components/autofill/core/browser/form_data_importer.cc [modify] https://crrev.com/6b32c1d4e2cb7569383651c02ec237792597f203/components/autofill/core/browser/form_data_importer.h [modify] https://crrev.com/6b32c1d4e2cb7569383651c02ec237792597f203/components/autofill/core/browser/form_data_importer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8203409e85fcc446337e142bdb58b9635cd391b5 commit 8203409e85fcc446337e142bdb58b9635cd391b5 Author: Hao Zhang <hozhng@google.com> Date: Tue Nov 13 19:21:40 2018 [Autofill] Browser tests for missing expiration date flow. Bug: 899057 Change-Id: I9a79e9a280ec0a937b44afd319f0dc3e516aef0f Reviewed-on: https://chromium-review.googlesource.com/c/1321471 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#607700} [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/views/autofill/dialog_view_ids.h [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc [modify] https://crrev.com/8203409e85fcc446337e142bdb58b9635cd391b5/components/test/data/autofill/credit_card_upload_form_address_and_cc.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/118efde1678c69ce77bf72ccd4198af2ad8a2300 commit 118efde1678c69ce77bf72ccd4198af2ad8a2300 Author: Hao Zhang <hozhng@google.com> Date: Thu Nov 15 05:35:42 2018 [Exp date fix flow] Disable Save Button When selecting expired expiration date Bug: 899057 Change-Id: I4d87ee3b3f12d0f76376976b0be0460b8b94c007 Reviewed-on: https://chromium-review.googlesource.com/c/1334228 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#608272} [modify] https://crrev.com/118efde1678c69ce77bf72ccd4198af2ad8a2300/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc [modify] https://crrev.com/118efde1678c69ce77bf72ccd4198af2ad8a2300/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d34aa4a2c928cf94ba83243b478d9cc7923b52cf commit d34aa4a2c928cf94ba83243b478d9cc7923b52cf Author: Hao Zhang <hozhng@google.com> Date: Wed Nov 21 19:12:01 2018 [Exp date fix flow] Handle user input expired expiration date Bug: 899057 Change-Id: Id1a0c15bfb3dbe8c0f1f967b25ce6dd7f2bd240e Reviewed-on: https://chromium-review.googlesource.com/c/1334928 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#610122} [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/autofill/core/browser/form_data_importer_unittest.cc [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/components/test/data/autofill/credit_card_upload_form_address_and_cc.html [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d34aa4a2c928cf94ba83243b478d9cc7923b52cf/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21eaf995826ea45ccc80aaa25cbf4a2e59453e59 commit 21eaf995826ea45ccc80aaa25cbf4a2e59453e59 Author: Hao Zhang <hozhng@google.com> Date: Tue Nov 27 21:39:43 2018 [Autofill] Do not show expiration date of expired cards in save bubble When offering save of expired credit cards with the expiration date fix flow, disables showing the outdated expiration date initially imported (because it will be changed to whatever the user enters in the fix flow anyway.) Bug: 899057 Change-Id: I79c1861046768f0f5470e4c73834784472f29f91 Reviewed-on: https://chromium-review.googlesource.com/c/1350880 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#611341} [modify] https://crrev.com/21eaf995826ea45ccc80aaa25cbf4a2e59453e59/chrome/browser/ui/views/autofill/dialog_view_ids.h [modify] https://crrev.com/21eaf995826ea45ccc80aaa25cbf4a2e59453e59/chrome/browser/ui/views/autofill/save_card_bubble_views.cc [modify] https://crrev.com/21eaf995826ea45ccc80aaa25cbf4a2e59453e59/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab3a59d5926baf4875e4dce4ac302bf82c8894d4 commit ab3a59d5926baf4875e4dce4ac302bf82c8894d4 Author: Hao Zhang <hozhng@google.com> Date: Sat Dec 08 01:45:21 2018 Add Autofill Expiration Date Missing Flow to waterfall testing config Bug: 899057 Change-Id: I6af9a3c4b00c4182ba7b9bb5fb74695b512c9ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1367093 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#614905} [modify] https://crrev.com/ab3a59d5926baf4875e4dce4ac302bf82c8894d4/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, Nov 3