[Downloads Home] Strange prefetch tab empty text with no tab panel. |
||||||||
Issue descriptionAlso the info menu shows up which doesn't do anything.
,
Oct 25
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30
Merge approved to 71, branch 3578.
,
Oct 30
,
Oct 30
Retested with M72 - 72.0.3596.0 Steps: 1. Enable flag Enable download Home V2 and Enable suggested offline pages to be prefetched When Download articles for you option is ON Not see any articles under Articles for you section.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb065850b325d8e84dc004ac1f7956d36a4f7e7e commit bb065850b325d8e84dc004ac1f7956d36a4f7e7e Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Oct 30 18:39:26 2018 Download Home : Fixed several bugs 1 - Prefetch tab empty string wasn't shown correctly 2 - My Files wasn't being shown when prefetch is not enabled 2 - Info menu was being shown incorrectly 3 - Externally deleted downloads were still being shown Bug: 899023 Change-Id: I5a2949810b77e06a7662757004a8992fe6985337 Reviewed-on: https://chromium-review.googlesource.com/c/1299666 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602870}(cherry picked from commit 943555078598db30faeee976991aad128f29f1bf) Reviewed-on: https://chromium-review.googlesource.com/c/1308261 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#410} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [delete] https://crrev.com/03437de13361fa344ff5e360cb6c217c50296198/chrome/android/java/src/org/chromium/chrome/browser/download/home/PrefetchStatusProvider.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java/src/org/chromium/chrome/browser/download/home/empty/EmptyCoordinator.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterCoordinator.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/InvalidStateOfflineItemFilter.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListCoordinator.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/ToolbarCoordinator.java [modify] https://crrev.com/bb065850b325d8e84dc004ac1f7956d36a4f7e7e/chrome/android/java_sources.gni
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb065850b325d8e84dc004ac1f7956d36a4f7e7e Commit: bb065850b325d8e84dc004ac1f7956d36a4f7e7e Author: shaktisahu@chromium.org Commiter: shaktisahu@chromium.org Date: 2018-10-30 18:39:26 +0000 UTC Download Home : Fixed several bugs 1 - Prefetch tab empty string wasn't shown correctly 2 - My Files wasn't being shown when prefetch is not enabled 2 - Info menu was being shown incorrectly 3 - Externally deleted downloads were still being shown Bug: 899023 Change-Id: I5a2949810b77e06a7662757004a8992fe6985337 Reviewed-on: https://chromium-review.googlesource.com/c/1299666 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602870}(cherry picked from commit 943555078598db30faeee976991aad128f29f1bf) Reviewed-on: https://chromium-review.googlesource.com/c/1308261 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#410} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 2
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 25