New issue
Advanced search Search tips

Issue 899010 link

Starred by 1 user
Status: WontFix
Owner:
est...@chromium.org
Closed: Oct 25
Cc:
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

"esc" doesn't cancel accidental command/control-D bookmarking

Reported by paulschr...@gmail.com, Oct 25 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce the problem:
1. Press Command-D
2. Press Escape

What is the expected behavior?
Bookmark is not saved

What went wrong?
Bookmark is saved

Did this work before? N/A 

Chrome version: 69.0.3497.100  Channel: n/a
OS Version: OS X 10.13.6
Flash Version: 

Bookmark should not be saved until Done is clicked. The … at the end of the menu item implies an additional step is required to complete the task.

Comment 1 by a...@chromium.org, Oct 25

Components: -UI UI>Browser>Omnibox
Labels: OS-Windows
Owner: pkasting@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: "esc" doesn't cancel accidental command/control-D bookmarking (was: "Bookmark This Page" automatically saves unexpectedly)
This is the case across all platforms.

Comment 2 by pkasting@chromium.org, Oct 25

Components: -UI>Browser>Omnibox UI>Browser>Bookmarks
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 3 by sky@chromium.org, Oct 25

Cc: sky@chromium.org
Owner: est...@chromium.org
Status: WontFix (was: Available)
Sadly this was an intentional change. Evan may remember the bug where this was discussed.

Comment 4 by est...@chromium.org, Oct 25 

commit 0bf4ced694bba0aeb3ba518c7fe8435bc9018674
Author: estade <estade@chromium.org>
Date:   Tue May 10 13:53:07 2016 -0700

    In dialogs & dialog-like bubbles, make the escape button just close
    the prompt.
    
    Previously, the escape button would activate the negative button, which
    was relevant if that button did anything extra in addition to closing
    the prompt.
    
    This intentionally changes the permissions bubble (back to what it
    was before) as well as the bookmark bubble (now escape doesn't
    remove a new bookmark). Other bubbles may be affected and
    those changes are *probably* desired.
    
    UX contacts for this decision are hwi@ and ainslie@
    
    BUG= 609079 ,163931
►

Sign in to add a comment