New issue
Advanced search Search tips

Issue 899001 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 898583



Sign in to add a comment

[UIDevTools] Distance calculation to pinned element is broken

Project Member Reported by weili@chromium.org, Oct 25

Issue description

Entering inspect mode and clicking on any element will pin the element. While the element is being pinned, hovering on another element should display the distances between the pinned element and the hovered element.
 
Blocking: 898583
Labels: Hotlist-DesktopUIConsider
Labels: Group-Developer_Tools
Labels: M-73 Target-73
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
*** UI Mass Triage ***

Seems like a valid bug, adding appropriate labels.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b847f9c1759f900bc7183a4fe2084f3c68f53ab2

commit b847f9c1759f900bc7183a4fe2084f3c68f53ab2
Author: Wei Li <weili@chromium.org>
Date: Tue Dec 11 22:10:19 2018

UIDevTools: Test pinned and hovered element calculation

The distance calculation was broken due to pinned element and
hovered element used different coordinates. r91bef92 also fixed
this issue. This CL refactored the function name to make the
coordinates used clearer, and also added unit test to prevent
future breakage.

BUG= 899001 

Change-Id: Ic1e2e577eb085a82f5ea32f608312335d6befd42
Reviewed-on: https://chromium-review.googlesource.com/c/1372551
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615684}
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/root_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/root_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/ui_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/overlay_agent_aura.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/overlay_agent_aura.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/overlay_agent_unittest.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/view_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/view_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/view_element_unittest.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/widget_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/widget_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/widget_element_unittest.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/window_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/views/window_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/viz_views/frame_sink_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/viz_views/frame_sink_element.h
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/viz_views/surface_element.cc
[modify] https://crrev.com/b847f9c1759f900bc7183a4fe2084f3c68f53ab2/components/ui_devtools/viz_views/surface_element.h

Status: Fixed (was: Started)

Sign in to add a comment