[UIDevTools] Fix minor highlighting issues |
||||
Issue descriptionWhen a hovered element is invisible, there should not be any node highlighted; In such case there is no need to show guidelines either.
,
Nov 1
,
Nov 1
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d421c4995a186ae572ba325c667f1e93bb92f43 commit 7d421c4995a186ae572ba325c667f1e93bb92f43 Author: Wei Li <weili@chromium.org> Date: Fri Nov 02 16:16:48 2018 UIDevTools: Don't highlight empty elements When an empty element is hovered, do not show a tiny highlighted square. There is no need to highlight in this case. However, for invisible non-empty element, we still show its bound for information. BUG= 898998 Change-Id: I8d5569710c427011dac90ec5ef9bc4dbc63eadd4 Reviewed-on: https://chromium-review.googlesource.com/c/1309413 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604945} [modify] https://crrev.com/7d421c4995a186ae572ba325c667f1e93bb92f43/components/ui_devtools/views/overlay_agent_aura.cc [modify] https://crrev.com/7d421c4995a186ae572ba325c667f1e93bb92f43/components/ui_devtools/views/overlay_agent_aura.h [modify] https://crrev.com/7d421c4995a186ae572ba325c667f1e93bb92f43/components/ui_devtools/views/overlay_agent_unittest.cc
,
Nov 2
We had discussion during code review, and decided to still highlight invisible ones, but not empty ones. So mark it as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by weili@chromium.org
, Oct 25