New issue
Advanced search Search tips

Issue 898990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

[iOS] WebViewAutofillTest.TestSuggestionFetchRemoveFetch needs to be reenabled.

Project Member Reported by jlebel@chromium.org, Oct 25

Issue description

WebViewAutofillTest.TestSuggestionFetchRemoveFetch has been disabled with crrev.com/c/1299006.

This test fails with ipad11-device-x64. See https://paste.googleplex.com/4823855352774656


 

Comment 1 Deleted

Components: Tests>Fails
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3d74dae3039d4a5c23054a54e5630e0788e1734

commit d3d74dae3039d4a5c23054a54e5630e0788e1734
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Oct 25 18:28:32 2018

[iOS] Disabling WebViewAutofillTest.TestSuggestionFetchRemoveFetch

WebViewAutofillTest.TestSuggestionFetchRemoveFetch fails with
ipad11-device-x64.

See: https://paste.googleplex.com/4823855352774656

TBR: jzw
Bug:  898990 
Change-Id: If4a5c704b4afe72a1dca3cdae1856a2d01fa738d
Reviewed-on: https://chromium-review.googlesource.com/c/1299006
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602802}
[modify] https://crrev.com/d3d74dae3039d4a5c23054a54e5630e0788e1734/ios/web_view/test/web_view_autofill_inttest.mm

Cc: linds...@chromium.org
Components: UI>Browser>Autofill
This was also failing on iphone11-device-x64. It started failing with this run on Oct 23:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/7553
Cc: mahmadi@chromium.org
Owner: jzw@chromium.org
I looked around for a bit but couldn't find an obvious reason. Mo, does anything jump out at you?
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642461c7870a4d35151ab5e384722cb9d23d0b18

commit 642461c7870a4d35151ab5e384722cb9d23d0b18
Author: John Z Wu <jzw@chromium.org>
Date: Mon Nov 19 04:13:23 2018

Update API for removing suggestions.

Add a return value to indicate if suggestion was allowed. Also fix
associated test.

Bug:  898990 
Change-Id: I22f00cef28dc5a82d431cc49191e956e47cd5e40
Reviewed-on: https://chromium-review.googlesource.com/c/1341148
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609175}
[modify] https://crrev.com/642461c7870a4d35151ab5e384722cb9d23d0b18/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/642461c7870a4d35151ab5e384722cb9d23d0b18/ios/web_view/public/cwv_autofill_controller.h
[modify] https://crrev.com/642461c7870a4d35151ab5e384722cb9d23d0b18/ios/web_view/test/web_view_autofill_inttest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment