[css-scroll-snap] Use gfx::RangeF for SnapVisibleRange |
||
Issue descriptionSince range.h includes windows.h, which pollutes the namespace, we have to create SnapVisibleRange class in scroll_snap_data.h. Now that windows.h has been removed, we should use gfx::RangeF for scroll_snap_data.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df4d1eaff502b3354efacfde798a1136dd2b200c commit df4d1eaff502b3354efacfde798a1136dd2b200c Author: Sandra Sun <sunyunjia@chromium.org> Date: Wed Oct 31 17:12:32 2018 Use gfx::RangeF for SnapVisibleRange Since range.h includes windows.h, which pollutes the namespace, we have to create SnapVisibleRange class in scroll_snap_data.h. Now that windows.h has been removed, we should use gfx::RangeF for scroll_snap_data. Bug: 898975 Change-Id: If86417f2d32f40f4560fe54ac1c1388e883518de Reviewed-on: https://chromium-review.googlesource.com/c/1308094 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#604307} [modify] https://crrev.com/df4d1eaff502b3354efacfde798a1136dd2b200c/cc/input/scroll_snap_data.cc [modify] https://crrev.com/df4d1eaff502b3354efacfde798a1136dd2b200c/cc/input/scroll_snap_data.h
,
Oct 31
|
||
►
Sign in to add a comment |
||
Comment 1 by yigu@chromium.org
, Oct 26