Running pwd in vsh sometimes fails with code 240 |
||
Issue descriptionThis happens in the automated testing on occassion, 11 times in the past month. The CrostiniStartEverything test fails with the reason "Failed to run pwd: exit status 240". If you look at the test output, it actually does print the result from pwd "/home/testuser". So the pwd command is actually succeeding, but for some reason vsh is returning a failure code. This has only been observed running the pwd command, which is the first thing run after the container is setup. We run a bunch of commands over vsh...and the other ones never fail like this. It looks like this is limited to Braswell boards as well. https://stainless.corp.google.com/search?view=list&first_date=2018-09-28&last_date=2018-10-25&test=%5Etast%5C.vm%5C.CrostiniStartEverything%24&status=FAIL&status=ERROR&status=ABORT&reason=Failed+to+run+pwd%3A+exit+status+240&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Nov 5
Aside from soraka, it appears every device showing this bug has 2GB of RAM.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/595db2c8a27964f8e66ddfb12ac80a09b21a965e commit 595db2c8a27964f8e66ddfb12ac80a09b21a965e Author: Stephen Barber <smbarber@chromium.org> Date: Fri Nov 16 13:02:08 2018 vm_tools: vsh: fix "exit status 240" race Fix a race in which the forwarder process would shut down before the client, leaving the client unable to read the exit status of the remote process. BUG= chromium:898973 TEST=vm.CrostiniStartEverything pwd works reliably Change-Id: Ib20bb5a7278e97f2ce2bb111ecb84904221994b6 Reviewed-on: https://chromium-review.googlesource.com/1332907 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/595db2c8a27964f8e66ddfb12ac80a09b21a965e/vm_tools/vsh/vsh_forwarder.cc [modify] https://crrev.com/595db2c8a27964f8e66ddfb12ac80a09b21a965e/vm_tools/vsh/vsh_forwarder.h [modify] https://crrev.com/595db2c8a27964f8e66ddfb12ac80a09b21a965e/vm_tools/vsh/vsh_client.cc
,
Nov 16
Verified on component 11267.0.0. Ran 40+ iterations of vm.CrostiniStartEverything. This would otherwise fail in < 10 iterations. |
||
►
Sign in to add a comment |
||
Comment 1 by smbar...@chromium.org
, Oct 25