Shelf has one-side sharp corner after screen rotation |
||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Switch to tablet mode (2) Rotate screen. What is the expected result? Shelf should still have rounded corner. What happens instead? Shelf has sharp corner on one side.
,
Oct 25
Hmm, not sure, I need to repro it myself. If you can get the version of the build where you saw this, it would help :-) (Basically whether it has cherry pick CL 1298945 or not).
,
Oct 25
I tested on my local build and it does not include the change, I will gclient sync and test again.
,
Oct 25
It still happens on ToT with the change. And I have stable repro steps: 1. Sign in in clamshell mode. 2. Maximize browser window. 3. Minimize browser window.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17fcbb10fbda992a8548b7f5373f3f13aa2f93dc commit 17fcbb10fbda992a8548b7f5373f3f13aa2f93dc Author: Weidong Guo <weidongg@chromium.org> Date: Sat Oct 27 01:05:34 2018 Fix shelf sharp corner after minimizing browser Bug: 890412 Change-Id: Ie72b42092292b26185386661bf29df9d3c7ee4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1303373 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#603277} [modify] https://crrev.com/17fcbb10fbda992a8548b7f5373f3f13aa2f93dc/ash/shelf/shelf_widget.cc
,
Oct 29
,
Oct 29
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Hi, has this been verified on ToT? What's the risk if we merge? Not seeing verification details noted in this bug.. Also note this is set as a P2 and we're already in Beta. Can it wait? Thanks
,
Oct 29
+kaznacheev@ for severity of the issue deciding whether we need the cherry-pick. This is one-line fix for UI issue, and should not have any risk.
,
Oct 29
Yes, this needs M71 merge. I actually think this should have been P1.
,
Oct 30
One line != No risk Did anyone verify it behaves as expected?
,
Oct 30
I manually tested on ToT with steps in #4 and description, it's no reproducible any more.
,
Oct 31
Approving merge to M71 Chrome OS. Thanks
,
Oct 31
It is merged, but the bug number was wrong: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5b37a14a201921949a388ebeb2f91523b72805c commit c5b37a14a201921949a388ebeb2f91523b72805c Author: Weidong Guo <weidongg@chromium.org> Date: Wed Oct 31 17:57:01 2018 Merge to M71: Fix shelf sharp corner after minimizing browser Bug: 890412 Change-Id: Ie72b42092292b26185386661bf29df9d3c7ee4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1303373 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603277}(cherry picked from commit 17fcbb10fbda992a8548b7f5373f3f13aa2f93dc) Reviewed-on: https://chromium-review.googlesource.com/c/1310675 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#434} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/c5b37a14a201921949a388ebeb2f91523b72805c/ash/shelf/shelf_widget.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by weidongg@chromium.org
, Oct 25