New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898957 link

Starred by 2 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Nov 23
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Investigate removal of components/sync_wifi

Project Member Reported by sdefresne@chromium.org, Oct 25 
From discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1298393:

> > > AFAIK wifi sync was never actually launched. Owning it will make it easier to delete the code, if and when we eventually decide to do that :)
> > 
> > Yes, looking at the code, I was wondering whether this was dead code or not. BTW, I think there is no reason to have this in components/ since it is only used by a single embedder (Chrome OS).
> > 
> > WDYT about moving this code chrome/browser/sync/wifi?
> 
> Well, I hope we can just delete it instead :)
> If for some reason that turns out to not be possible, then moving SGTM.

So, the code should probably be removed if this has effectively never been launched.

Comment 1 by mastiz@chromium.org, Oct 26

Labels: -Pri-3 sync-fixit-2018q4 Sync-Triaged Pri-2
Status: Available (was: Untriaged)

Comment 2 by treib@chromium.org, Oct 30 

I think the relevant feature request is  bug 182649 .

Comment 3 by treib@chromium.org, Nov 22 

I have emailed the (previous) feature owners, but not received a reply yet. A previous question on  bug 182649  from Oct 30 also got no answer. I'm gonna go ahead and say this is safe to remove. People can always pull it back out of git history if it's really required.

Comment 4 by treib@chromium.org, Nov 22

Cc: -treib@chromium.org
Labels: OS-Chrome
Owner: treib@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/1348089/
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9c3b31ff2a543dccb27e63a6716af424c33e94d

commit c9c3b31ff2a543dccb27e63a6716af424c33e94d
Author: Marc Treib <treib@chromium.org>
Date: Fri Nov 23 09:29:26 2018

Delete components/sync_wifi

It was never finished or launched, hasn't been touched in years, and is
unowned.

Bug:  898957 ,  182649 
Change-Id: I8b5d04c7ac271031b7fb84235fd6c12def3b5fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1348089
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610555}
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/BUILD.gn
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/about_flags.cc
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/browser/sync/profile_sync_service_factory.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/two_client_wifi_credentials_sync_test.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/wifi_credentials_helper.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/wifi_credentials_helper.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.h
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/chrome/test/BUILD.gn
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/components/BUILD.gn
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/components/browser_sync/browser_sync_switches.cc
[modify] https://crrev.com/c9c3b31ff2a543dccb27e63a6716af424c33e94d/components/browser_sync/browser_sync_switches.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/BUILD.gn
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/DEPS
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/OWNERS
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/network_state_helper_chromeos.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/network_state_helper_chromeos.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_config_delegate.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_config_delegate_chromeos.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_config_delegate_chromeos.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_config_delegate_chromeos_unittest.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_syncable_service.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_syncable_service.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_syncable_service_factory.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_syncable_service_factory.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_syncable_service_unittest.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_credential_unittest.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_security_class.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_security_class.h
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_security_class_chromeos.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_security_class_chromeos_unittest.cc
[delete] https://crrev.com/fb01e63b5520da87becf61f27a2e086fbbc1b520/components/sync_wifi/wifi_security_class_unittest.cc

Comment 6 by treib@chromium.org, Nov 23

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56782876ba8b8b46157b4dc0ac856236d93640ee

commit 56782876ba8b8b46157b4dc0ac856236d93640ee
Author: Marc Treib <treib@chromium.org>
Date: Sat Nov 24 07:51:52 2018

Deprecate Sync model type syncer::WIFI_CREDENTIALS

The corresponding feature was never launched, and its code was
recently deleted (https://crrev.com/c/1348089).

Bug:  898957 
Change-Id: I12eb6de7531c6fa5ffff34cf86ff5f7c1752fef6
Reviewed-on: https://chromium-review.googlesource.com/c/1349223
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610698}
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/PRESUBMIT.py
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/base/data_type_histogram.h
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/base/model_type.h
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/driver/model_association_manager.cc
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/engine/sync_encryption_handler.cc
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc
[modify] https://crrev.com/56782876ba8b8b46157b4dc0ac856236d93640ee/components/sync/syncable/model_type.cc
►

Sign in to add a comment