This CL:https://chromium-review.googlesource.com/c/chromium/src/+/1280249 is ready and it is checked manually that everything is working as expected, but unittests have to be written for consistency in gaia_auth_fetcher_ios_unittests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5717fa850bfd7f40c8c2700d3957bf407994ab9c commit 5717fa850bfd7f40c8c2700d3957bf407994ab9c Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Dec 19 12:11:13 2018 [iOS] Using NSURLSession for GAIAAuthFetcheriOS Adding sub class of GaiaAuthFetcherIOSBridge to use NSURLSession: GaiaAuthFetcherIOSNSURLSessionBridge. GaiaAuthFetcherIOS can either use GaiaAuthFetcherIOSNSURLSessionBridge or GaiaAuthFetcherIOSWKWebViewBridge to fetch request. |use-nsurlsession-for-signin| flag is added to be able to user one or the other class to fetch request from GaiaAuthFetcherIOS. GaiaAuthFetcherIOSNSURLSessionBridge can only be used when |web::features::kWKHTTPSystemCookieStore| is enabled (see http://crbug.com/902584 ). This patch is to replace: crrev.com/c/1280249 Bug: 889471, 898956 Change-Id: If05acd7c0f2a65a18348689aedbdae1f80c20724 Reviewed-on: https://chromium-review.googlesource.com/c/1373109 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#617805} [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/BUILD.gn [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/feature_flags.h [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/feature_flags.mm [modify] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm [add] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/gaia_auth_fetcher_ios_ns_url_session_bridge.h [add] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/gaia_auth_fetcher_ios_ns_url_session_bridge.mm [add] https://crrev.com/5717fa850bfd7f40c8c2700d3957bf407994ab9c/ios/chrome/browser/signin/gaia_auth_fetcher_ios_ns_url_session_bridge_unittests.mm
Comment 1 by kkhorimoto@chromium.org
, Oct 25