New issue
Advanced search Search tips

Issue 898955 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 755921



Sign in to add a comment

Convert prerender browsertests to nostate-prefetch tests when tested functionality overlaps

Project Member Reported by pasko@chromium.org, Oct 25

Issue description

We have some good coverage in prerender_nostate_prefetch_browsertest.cc. However, we still rely on some coverage from prerender_browsertest.cc. To check against the nostate-prefetch system those tests will likely need to be rewritten: we cannot run checks on an idle renderer in background, instead we would be waiting on network requests.

I scanned prerender_browsertest.cc for cases that seem uncovered and may happen with nostate-prefetch (mostly reasons for canceling). Here is what I found, with related tests that come to mind:

PrerenderPageRemovesPending
PrerenderPageRemovingLink
PrerenderPageRemovingLinkWithTwoLinks
PrerenderPageRemovingLinkWithTwoLinksOneLate
PrerenderPageRemovingLinkWithTwoLinksRemovingOne

// Checks that client redirects don't add alias URLs until after they commit.
PrerenderNoCommitNoSwap2

// Checks plugins (NaCl is still supported) - replace with: NaCl plugin does not
load
// Old:
PrerenderDelayLoadPlugin
PrerenderPluginPowerSaver
MAYBE_PrerenderNaClPluginEnabled
// New:
//   * check that plugins are not loaded
//   * check that NaCl plugin does not load

PrerenderHttpAuthentication

// New:
//   * make sure that JS from iframe does not run. Special case to check:
//     the frame is forced to be out of process.

// FINAL_STATUS_DOWNLOAD
PrerenderDownloadIframe

PrerenderReferrer
PrerenderNoSSLReferrer
PrerenderCancelReferrer

PrerenderQuickQuit
OpenTaskManagerBeforePrerender
OpenTaskManagerAfterPrerender
PrerenderHTML5Audio

PrerenderHTML5AudioAutoplay
PrerenderHTML5Video
// New:
//   * insert DOM element: <video controls autoplay>

PrerenderPageWithFragment
PrerenderPageWithRedirectedFragment
PrerenderSSLClientCertTopLevel
PrerenderSSLClientCertSubresource
PrerenderSSLClientCertIframe
PrerenderSafeBrowsingServerRedirect
PrerenderSafeBrowsingIframe
PrerenderFavicon
PrerenderClearHistory
PrerenderClearCache
PrerenderReferrerPolicy
PrerenderSSLReferrerPolicy

// NoStatePrefetch has an "unsupported scheme" test, but not with redirects.
PrerenderCancelMainFrameRedirectUnsupportedScheme

 
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment