Deterministic build checking currently doesn't check files not in isolates |
|||||
Issue descriptionThe deterministic build check used to check files based on an extension whitelist. This missed a bunch of files we pack up in isolates, so we changed things so that we compare everything referenced from isolates instead ( issue 870731 ). That's great, but now a handful of files that aren't referenced from isolates but are produced as part of the build aren't checked anymore, e.g. policy_templates.zip (which we ship: https://cs.chromium.org/chromium/src/chrome/tools/build/win/FILES.cfg?q=policy_templates.zip&sq=package:chromium&g=0&l=321) on Windows. What, if anything, should we do about this? - Add those files to a dummy isolate - Explicitly check for them - Don't care about them and remove entries for them from the whitelist? - your suggestion here
,
Oct 25
> That's great, but now a handful of files that aren't referenced from isolates but are produced as part of the build aren't checked anymore, e.g. policy_templates.zip Does that mean they're not tested anywhere as well? That sounds like a problem with test coverage and we should at least get some basic test coverage.
,
Oct 25
atwilson, does it make sense to test the contents of policy_templates.zip?
,
Nov 20
atwilson, ping for the question in comment 3
,
Nov 20
,
Nov 23
Lutz, PTAL |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Oct 25Status: Untriaged (was: Unconfirmed)