Fade out the darker background of the toolbar instead of having it disappear abruptly |
||||
Issue descriptionChrome Version: M72 What steps will reproduce the problem? (1) Press and hold on the address bar (2) Move the finger out of the address bar to highlight/unhighlight it What is the expected result? The darker background should fade in/out with an animation. What happens instead? It is (dis)appearing without animation, creating an abrupt feeling.
,
Dec 3
,
Dec 4
What should the animation duration be? Looking at the original CL (https://chromium-review.googlesource.com/c/chromium/src/+/1228058/), the consensus there was 0.1 for both fade-in and fade-out.
,
Dec 4
Can you create the same feeling like on Safari? The fade-out animation feels different when you compare the two. Will increasing the duration satisfy that?
,
Dec 5
Yeah, I think the difference is that on Safari, the fade-out animation is longer than the fade in. I'll take a look there.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dca156ed5078a990c7692dc166ffb8e7e73814a commit 1dca156ed5078a990c7692dc166ffb8e7e73814a Author: Robbie Gibson <rkgibson@google.com> Date: Wed Dec 05 10:58:23 2018 [iOS] Fix steady view highlight animation duration This CL changes the duration of the steady view highlight fade-out animation duration to be longer. Bug: 898951 Change-Id: I33ce83968894ad363976cf25a1320fbef094a7e1 Reviewed-on: https://chromium-review.googlesource.com/c/1362893 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#613933} [modify] https://crrev.com/1dca156ed5078a990c7692dc166ffb8e7e73814a/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
,
Dec 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pschaffner@chromium.org
, Oct 26