[AF Android] UX polish issues |
|||||||
Issue descriptionThe following visible issues were identified during UX passes on the refresh UI: * Tap effects are needed on footer rows * Footer icon should be 14dp (vs. 16dp elsewhere), and icons should have explicit sizes * Multiline items (e.g., http insecure warning) should wrap, not elide, and expand the popup height.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf commit 9126cd60c2c7135edd7ca749a9db9edbab1cf7cf Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Oct 26 20:05:39 2018 [AF Android] Addressing UX polish concerns This CL corrects the following outstanding UX polish concerns: * Tap effects are needed on footer rows * Footer icon should be 14dp (vs. 16dp elsewhere), and icons should have explicit sizes * Multiline items (e.g., http insecure warning) should wrap, not elide, and expand the popup height. BUG: 898927 Change-Id: Ibe50c6ddea98dcdf91bc1d82e548b651ba486b37 Reviewed-on: https://chromium-review.googlesource.com/c/1297400 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603179} [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/components/autofill/android/java/res/layout/autofill_dropdown_footer_item_refresh.xml [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/components/autofill/android/java/res/layout/autofill_dropdown_item_refresh.xml [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/components/autofill/android/java/res/values/dimens.xml [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/components/autofill/android/java/src/org/chromium/components/autofill/AutofillDropdownAdapter.java [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/ui/android/java/res/layout/dropdown_item.xml [modify] https://crrev.com/9126cd60c2c7135edd7ca749a9db9edbab1cf7cf/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java
,
Oct 26
,
Oct 26
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30
Merge approved to 71, branch 3578.
,
Oct 30
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5 commit 43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Nov 01 16:27:12 2018 [AF Android] Addressing UX polish concerns This CL corrects the following outstanding UX polish concerns: * Tap effects are needed on footer rows * Footer icon should be 14dp (vs. 16dp elsewhere), and icons should have explicit sizes * Multiline items (e.g., http insecure warning) should wrap, not elide, and expand the popup height. BUG: 898927 Change-Id: Ibe50c6ddea98dcdf91bc1d82e548b651ba486b37 Reviewed-on: https://chromium-review.googlesource.com/c/1297400 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603179}(cherry picked from commit 9126cd60c2c7135edd7ca749a9db9edbab1cf7cf) Reviewed-on: https://chromium-review.googlesource.com/c/1312678 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#445} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/components/autofill/android/java/res/layout/autofill_dropdown_footer_item_refresh.xml [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/components/autofill/android/java/res/layout/autofill_dropdown_item_refresh.xml [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/components/autofill/android/java/res/values/dimens.xml [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/components/autofill/android/java/src/org/chromium/components/autofill/AutofillDropdownAdapter.java [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/ui/android/java/res/layout/dropdown_item.xml [modify] https://crrev.com/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5 Commit: 43d08427cbce8cf42d0b898d1ecfc3dde4e8c9b5 Author: ftirelo@chromium.org Commiter: tmartino@chromium.org Date: 2018-11-01 16:27:12 +0000 UTC [AF Android] Addressing UX polish concerns This CL corrects the following outstanding UX polish concerns: * Tap effects are needed on footer rows * Footer icon should be 14dp (vs. 16dp elsewhere), and icons should have explicit sizes * Multiline items (e.g., http insecure warning) should wrap, not elide, and expand the popup height. BUG: 898927 Change-Id: Ibe50c6ddea98dcdf91bc1d82e548b651ba486b37 Reviewed-on: https://chromium-review.googlesource.com/c/1297400 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603179}(cherry picked from commit 9126cd60c2c7135edd7ca749a9db9edbab1cf7cf) Reviewed-on: https://chromium-review.googlesource.com/c/1312678 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#445} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tmartino@chromium.org
, Oct 25