New issue
Advanced search Search tips

Issue 898832 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Nov 14
Cc:
perezju@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stop running start_with_url.* benchmarks on fyi bots

Project Member Reported by perezju@chromium.org, Oct 25 
Found this because, somehow, the fyi bots are still attempting to run this benchmark:

No benchmark named "start_with_url.cold.startup_pages".

Do you mean any of those benchmarks below?
Available benchmarks are:
  system_health.webview_startup Webview startup time benchmark
Pass --browser to list benchmarks for another browser.

https://chrome-swarming.appspot.com/task?id=40c317ae52e28d10&refresh=10&show_raw=1

Comment 1 by perezju@chromium.org, Oct 25 

I think we would like this to become empty:
https://cs.chromium.org/search/?q=start_with_url+-file:testdata/task_output+-file:%5Esrc/third_party/android_tools+-file:%5Einfra/infra/services/android_docker&type=cs

Also not sure about the data in testdata/task_output/ do we run the risk of that becoming stale?

Comment 2 by perezju@chromium.org, Oct 25

Cc: -nedngu...@google.com perezju@chromium.org
Owner: nedngu...@google.com
Status: Assigned (was: Started)
Summary: Stop running start_with_url.* benchmarks on fyi bots (was: Remove references to non-existent start_with_url.* benchmark)
Actually, I'm pretty lost at how to do this.

Ned, do we have any documentation on how to update perf configs, add/remove benchmarks, update shard maps, etc.? I know the commands are there but I have to rediscover all of this every time I need to make a change in this area.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86

commit 0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Nov 13 14:26:31 2018

Add timing data & regenerate shard maps for FYI perf builders

With this CL, perf FYI builders sharding data can be generated by running:
$ ./tools/perf/generate_perf_sharding update -w perf-fyi -r

This CL also remove 'One Buildbot Step Test Builder' in
perf.fyi.json since the corresponding builder has been removed.

BUG: chromium:898832 

Change-Id: I7caf239d55259b95418750bdecf3ccb4d6e94398
Reviewed-on: https://chromium-review.googlesource.com/c/1318682
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#607581}
[modify] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/perf_json_config_validator.py
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/android-go_webview-perf_map.json
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/android-nexus5x-perf-fyi_map.json
[rename] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/android-pixel2-perf_map.json
[copy] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/android-pixel2_webview-perf_map.json
[delete] https://crrev.com/3756c9f0e47b869cb1c55f324bd09a4384dbc5e2/tools/perf/core/shard_maps/android_go_webview_shard_map.json
[delete] https://crrev.com/3756c9f0e47b869cb1c55f324bd09a4384dbc5e2/tools/perf/core/shard_maps/android_nexus5x_fyi_4_shard_map.json
[delete] https://crrev.com/3756c9f0e47b869cb1c55f324bd09a4384dbc5e2/tools/perf/core/shard_maps/android_pixel2_webview_shard_map.json
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/timing_data/android-go_webview-perf_timing.json
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/timing_data/android-nexus5x-perf-fyi_timing.json
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/timing_data/android-pixel2-perf_timing.json
[add] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/core/shard_maps/timing_data/android-pixel2_webview-perf_timing.json
[modify] https://crrev.com/0d2d04f6f9fa393d53d0d6e1720e1e99d9065b86/tools/perf/generate_perf_sharding

Comment 4 by nedngu...@google.com, Nov 14

Status: Fixed (was: Assigned)
I think this is fixed. Feel free to reopen if that's not the case
►

Sign in to add a comment