New issue
Advanced search Search tips

Issue 898830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary ripple effect is seen on disabled Delete icon in Choose your Pin screen

Project Member Reported by kebalaji@chromium.org, Oct 25

Issue description

Chrome Version: 71.0.3578.21/11151.11.0 dev-channel Kip,Daisy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Sign-in to user>> In Choose your Pin screen, try clicking on the disabled Delete icon and observe unnecessary ripple effect

Actual: Unnecessary ripple effect is seen on disabled Delete icon 
Expected: No such issue should be seen

This is a Regression issue as same is working fine in 72.0.3582.0/11176.0.0 dev and able to reproduce the issue on 72.0.3589.0/11187.0.0 dev

Attaching screencasts for reference..
 
ActualRippleeffect.mp4
2.5 MB View Download
ExpectedRippleeffect.mp4
1.5 MB View Download
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2471317e9f7412ce50711718ca39058aaa3f8d45

commit 2471317e9f7412ce50711718ca39058aaa3f8d45
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Nov 01 22:50:46 2018

Chrome OS: Hide ripple effect on back button when it is disabled.

This CL hides ripple effect on "Backspace" button when it is disabled.

Bug:  898830 
Change-Id: Ie77e0f0846a707be4d288c1762d4775403ad32d5
Reviewed-on: https://chromium-review.googlesource.com/c/1312309
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604735}
[modify] https://crrev.com/2471317e9f7412ce50711718ca39058aaa3f8d45/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html

Status: Fixed (was: Assigned)
Labels: -M-71 FoundIn-71 M-72
Moving this to M72

Sign in to add a comment