Replace uses of TracingControllerAndroid's BroadcastReceiver with DevTools |
||||
Issue descriptionadb_profile_chrome.sh is currently sending intents to start/stop Chrome tracing (and it's likely the only user of this intent-based API). It should really be using the DevTools API for this purpose instead.
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd commit f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd Author: Torne (Richard Coles) <torne@google.com> Date: Thu Jan 17 15:31:41 2019 Only enable tracing broadcasts on debug Android. Don't register the tracing broadcast receiver unless we're on a debug build of the OS. Regular usage of tracing should be using the DevTools API, not the old adb_profile_chrome script that uses this broadcast. Bug: 898816, 922627 Change-Id: Ibf172dab29da878000ab60f48bed6e1862aa35e8 Reviewed-on: https://chromium-review.googlesource.com/c/1416171 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#623691} [modify] https://crrev.com/f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java
,
Jan 17
(5 days ago)
Disabled on user builds as a first step toward completely removing it.
,
Today
(10 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318a79045ace18d73e1115d086599e036d0496ba commit 318a79045ace18d73e1115d086599e036d0496ba Author: Torne (Richard Coles) <torne@google.com> Date: Tue Jan 22 21:33:06 2019 Only enable tracing broadcasts on debug Android. Don't register the tracing broadcast receiver unless we're on a debug build of the OS. Regular usage of tracing should be using the DevTools API, not the old adb_profile_chrome script that uses this broadcast. TBR=torne@google.com (cherry picked from commit f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd) Bug: 898816, 922627 Change-Id: Ibf172dab29da878000ab60f48bed6e1862aa35e8 Reviewed-on: https://chromium-review.googlesource.com/c/1416171 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#623691} Reviewed-on: https://chromium-review.googlesource.com/c/1427386 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#764} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/318a79045ace18d73e1115d086599e036d0496ba/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java
,
Today
(10 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318a79045ace18d73e1115d086599e036d0496ba Commit: 318a79045ace18d73e1115d086599e036d0496ba Author: torne@google.com Commiter: torne@chromium.org Date: 2019-01-22 21:33:06 +0000 UTC Only enable tracing broadcasts on debug Android. Don't register the tracing broadcast receiver unless we're on a debug build of the OS. Regular usage of tracing should be using the DevTools API, not the old adb_profile_chrome script that uses this broadcast. TBR=torne@google.com (cherry picked from commit f68b18e1ec1cadb432998d3ccc084e0a8c1ae5cd) Bug: 898816, 922627 Change-Id: Ibf172dab29da878000ab60f48bed6e1862aa35e8 Reviewed-on: https://chromium-review.googlesource.com/c/1416171 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#623691} Reviewed-on: https://chromium-review.googlesource.com/c/1427386 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#764} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||
►
Sign in to add a comment |
||||
Comment 1 by eseckler@chromium.org
, Oct 25