New issue
Advanced search Search tips

Issue 898812 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in v8::internal::FuncNameInferrer::RemoveAsyncKeywordFromEnd

Project Member Reported by ClusterFuzz, Oct 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6427577663881216

Fuzzer: afl_v8_fully_instrumented_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x0000024c5ca8
Crash State:
  v8::internal::FuncNameInferrer::RemoveAsyncKeywordFromEnd
  v8::internal::ParserBase<v8::internal::Parser>::ParseLeftHandSideContinuation
  ParseLeftHandSideExpression
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=599963:599969

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427577663881216

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 25

Components: Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 25

Cc: metzman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Oct 25

Cc: verwa...@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[parser] Restructure ParseLeftHandSide by verwaest@chromium.org - https://chromium.googlesource.com/v8/v8/+/ee9ac86ad9999b9ebf4bc89915b6104494aa7ba9

[parser] Simplify detecting async arrow functions by verwaest@chromium.org - https://chromium.googlesource.com/v8/v8/+/26b47aafb388c263b8ece502a3de16b32cc36676

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Owner: verwa...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1efaf460583a793310be7150280f7cf61d608b9c

commit 1efaf460583a793310be7150280f7cf61d608b9c
Author: Toon Verwaest <verwaest@chromium.org>
Date: Fri Oct 26 07:54:44 2018

[parser] Only parse async parenthesized arrow if current_token == ASYNC

Checking impl()->IsAsync(identifier) is insufficient since it could be
parenthesized. By checking the token in addition to IsIdentifier guarantees
that we've only seen the single token ASYNC.

Bug:  chromium:898812 
Change-Id: Id94dd607381050b4bd8cd6d8672a5d11256db7da
Reviewed-on: https://chromium-review.googlesource.com/c/1300134
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57013}
[modify] https://crrev.com/1efaf460583a793310be7150280f7cf61d608b9c/src/parsing/parser-base.h
[add] https://crrev.com/1efaf460583a793310be7150280f7cf61d608b9c/test/mjsunit/regress/regress-898812.js

Project Member

Comment 6 by ClusterFuzz, Oct 27

ClusterFuzz has detected this issue as fixed in range 603066:603073.

Detailed report: https://clusterfuzz.com/testcase?key=6427577663881216

Fuzzer: afl_v8_fully_instrumented_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x0000024c5ca8
Crash State:
  v8::internal::FuncNameInferrer::RemoveAsyncKeywordFromEnd
  v8::internal::ParserBase<v8::internal::Parser>::ParseLeftHandSideContinuation
  ParseLeftHandSideExpression
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=599963:599969
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=603066:603073

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427577663881216

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 27

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6427577663881216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment