New issue
Advanced search Search tips

Issue 898806 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Oct 31
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Grey focus highlight does not fill the blue focus ring completely on Find-in page bubble.

Reported by sanyam.g...@etouch.net, Oct 25 
Chrome Version: 72.0.3590.0 (Official Build)Revision ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1} (64 Bit). 
OS: Mac(10.13.1, 10.13.6, 10.14.1)

What steps will reproduce the problem?
1. Launch Chrome, press command+f to open find-in page bubble.
2. Press tab key to bring focus to close button (X).
3. Hover mouse on close button (X) while the blue focus ring is still present and observe.

Actual Result  : Grey focus highlight does not fill the blue focus ring completely. 
Expected Result: Grey focus highlight should fill the blue focus ring completely.
          
This is a non-regression issue, seen from M70 (build #70.0.3516.0) as blue focus ring is introduced from this build.

Kindly refer attached screen cast.

Note: Issue is specific to Mac(10.13.1, 10.13.6, 10.14.1) OS.

Thank you
Actual_Result.mov
5.6 MB View Download

Comment 1 by rbasuvula@chromium.org, Oct 25

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by a...@chromium.org, Oct 25

Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Elly, you worked on focus rings.

Comment 3 by ellyjo...@chromium.org, Oct 29

Owner: pbos@chromium.org
Over to pbos@ :)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f516bb765d0b90d855e2c40a6a500d01905b3b77

commit f516bb765d0b90d855e2c40a6a500d01905b3b77
Author: Peter Boström <pbos@chromium.org>
Date: Wed Oct 31 17:38:25 2018

Use circular highlight path for find and zoom bars

This is consistent with the new close-x on bubbles. It also fixes ink
drops being out of sync with focus rings on Mac, since they were not
derived from the same path.

Bug:  chromium:898806 
Change-Id: I51ebd333b60435fee4b252a4db60e7ca459cea0d
Reviewed-on: https://chromium-review.googlesource.com/c/1309136
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604318}
[modify] https://crrev.com/f516bb765d0b90d855e2c40a6a500d01905b3b77/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/f516bb765d0b90d855e2c40a6a500d01905b3b77/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/f516bb765d0b90d855e2c40a6a500d01905b3b77/chrome/browser/ui/views/location_bar/zoom_bubble_view.h

Comment 5 by pbos@chromium.org, Oct 31

Status: Fixed (was: Assigned)

Comment 6 by sanyam.g...@etouch.net, Nov 1

Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
Update:

Rechecked the above issue on  Mac(10.13.1 , 10.13.6 , 10.14.1) using latest canary build #72.0.3598.0 and issue is fixed.
Please refer attached screen cast.

Thank You..!!
Fixed_Behaviour.mov
1.1 MB View Download
►

Sign in to add a comment