New issue
Advanced search Search tips

Issue 898802 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Nov 26
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Error message on print preview is seen chopped after changing browser language.

Reported by pranjali...@etouch.net, Oct 25 
Chrome Version: 72.0.3590.0 (Official Build) ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1}(32/64 bit)

OS:  Win(7,8,8.1,10) OS

What steps will reproduce the problem?
1.Launch chrome ,navigate to 'chrome://settings/languages' and change browser language to Tamil.
2.Give print command and enter some text in pages textbox such that error message should appear.
3.Observe.

Actual  : Error message on print preview is seen chopped  after changing browser language.
Expected: Error message on print preview should not be seen chopped  after changing browser language.

This is Regression issue seen in M-71, and will soon update other info.
Good Build: 71.0.3575.0
Bad Build: 71.0.3576.0

Unable to provide 'per-revision' bisect as it shows "RuntimeError : We don't have enough builds to bisect..." error message for above range. 
Hence provided suspect through 'Chromium bisect'.

Chromium bisect info:
  
https://chromium.googlesource.com/chromium/src/+log/af9906ef20544c312f97d8774e045139758da24a..33d2f351e23d3db6fbbee5d0835aeaffd997e910	

Suspecting: https://chromium.googlesource.com/chromium/src/+/33d2f351e23d3db6fbbee5d0835aeaffd997e910

@rbpotter: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Issue is not seen on Mac(10.13.1 , 10.13.6 , 10.14.1)  and Linux(14.04 LTS)

Thank You
Actual Result.png
148 KB View Download
Expected Result.png
148 KB View Download

Comment 1 by rbpotter@chromium.org, Nov 1

Labels: -Pri-1 Pri-3
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ede47e3b1552739bc556b038ebbef082cf5fcce

commit 7ede47e3b1552739bc556b038ebbef082cf5fcce
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Nov 22 07:25:57 2018

Print Preview: Fix error messages for large fonts/languages

Error messages currently appear cut off for large fonts and languages
that cause the messages to wrap onto more than 2 lines.

Size error messages to the full height of the text content and update
styling so that the labels stay aligned with the input when error
messages appear.

Bug:  898802 , 887992
Change-Id: I07036adc127cd9fa95ddede51c44790c867e31ba
Reviewed-on: https://chromium-review.googlesource.com/c/1345544
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610330}
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

Comment 3 by pranjali...@etouch.net, Nov 23

Labels: TE-Verified-M72 TE-Verified-72.0.3619.0
Update:

Rechecked the above issue using latest canary build #72.0.3619.0 on Win(7,8,10)Os and issue is fixed.

Please refer attached screencast for same.

Thank You..
Canary Behaviour.mp4
679 KB View Download

Comment 4 by rbpotter@chromium.org, Nov 26

Status: Verified (was: Assigned)
►

Sign in to add a comment