New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-29
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Merge debug message CL to M71

Project Member Reported by philipel@chromium.org, Oct 25

Issue description

This is a CL that simply change one RTC_LOG to an RTC_DLOG, so there is no risk involved.

We want to merge this in order to avoid spamming the log with something that is a debug message and not that useful for the user (it only cause confusion).

CL here: https://webrtc-review.googlesource.com/c/src/+/107688
 
Pls update the bug with canary result tomorrow. If change looks good in Canary, I will approve the merge. Thank you.
NextAction: 2018-10-26
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 25

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The NextAction date has arrived: 2018-10-26
NextAction: 2018-10-29
Ah, ok. Pls update bug with canary result on Monday morning.
The CL landed 4 days ago, and still not part of any build so far.
The NextAction date has arrived: 2018-10-29
We're building canary everyday. Pls check canary version #72.0.3595.0 on Windows & Mac. CL should be there.

The link you gave at #5 is for Android canary which has been failing to push due to bug  899461. Thank you.


Everything looks well, can't find any problems with the CL.
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #10.  Please merge ASAP, so we can pick it up for this week beta. Thank you.
Shouldn't this bug be "Fixed" status before cherrypick?
Status: Fixed (was: Untriaged)
Merged here: https://webrtc-review.googlesource.com/c/src/+/108582/1
Labels: -Merge-Approved-71 Merge-Merged

Sign in to add a comment