New issue
Advanced search Search tips

Issue 898791 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 898769



Sign in to add a comment

Performance Timeline WPT failures

Project Member Reported by tdres...@chromium.org, Oct 25

Issue description

Blocking: 898769
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb71dd3df12c0658b678b68cac27d17403c97e8

commit 8bb71dd3df12c0658b678b68cac27d17403c97e8
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Nov 29 19:26:30 2018

Expose PerformanceMark and PerformanceMeasure to workers

This CL exposes the PerformanceMark and PerformanceMeasure interfaces to Worker,
thus fixing the idlharness tests in performance-timeline and user-timing.

Blink-dev thread:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ

Bug:  898791 
Change-Id: Ic4e3e8c61ac087d13ffc86e462b45ab2ddbd097f
Reviewed-on: https://chromium-review.googlesource.com/c/1351562
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612309}
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/renderer/core/timing/performance_mark.idl
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/renderer/core/timing/performance_measure.idl
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/performance-timeline/idlharness.any.serviceworker-expected.txt
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/performance-timeline/idlharness.any.sharedworker-expected.txt
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/performance-timeline/idlharness.any.worker-expected.txt
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/user-timing/idlharness.any.serviceworker-expected.txt
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/user-timing/idlharness.any.sharedworker-expected.txt
[delete] https://crrev.com/43757e7714c20069a33afeeb2572380d159e5b01/third_party/blink/web_tests/external/wpt/user-timing/idlharness.any.worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/8bb71dd3df12c0658b678b68cac27d17403c97e8/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

npm@ - can we close this one?
No, there's still po-observe failing. I'll take a look at it.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e9fe0c7ad77c910dac445afd4bf652b3c9eb4e

commit 45e9fe0c7ad77c910dac445afd4bf652b3c9eb4e
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Dec 12 22:32:36 2018

[PerformanceTimeline] Do not throw error when observing invalid types

This CL uses a console warning instead of error when entryTypes is
invalid, which aligns our implementation with the spec and fixes a
test in Performance Timeline. It also removes a stray .expected file.

Bug:  898791 

Change-Id: Ie0a0eb0ab4889a062258aab0f3fd967191f1f430
Reviewed-on: https://chromium-review.googlesource.com/c/1374168
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616087}
[modify] https://crrev.com/45e9fe0c7ad77c910dac445afd4bf652b3c9eb4e/third_party/blink/renderer/core/timing/performance_observer.cc
[delete] https://crrev.com/a3311e209e39869ad5a76394d39faab91c1b99cd/third_party/blink/web_tests/external/wpt/performance-timeline/po-navigation-expected.txt
[delete] https://crrev.com/a3311e209e39869ad5a76394d39faab91c1b99cd/third_party/blink/web_tests/external/wpt/performance-timeline/po-observe.any-expected.txt
[delete] https://crrev.com/a3311e209e39869ad5a76394d39faab91c1b99cd/third_party/blink/web_tests/external/wpt/performance-timeline/po-observe.any.worker-expected.txt

Status: Fixed (was: Assigned)
Marking this as fixed because the last test left is about buffered flag, which hasn't been implemented yet and will change with the new format of observe()

Sign in to add a comment