New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 19
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename base/trace_event/trace_event_argument.h to traced_value.h

Project Member Reported by digit@google.com, Oct 25

Issue description

The base/trace_event/trace_event_argument.h header is now, after several refactoring steps, only used to declare the TracedValue class.

It would be more logical to rename it to traced_value.h instead, and update all other sources that include it to use the new header name, hence this bug.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6ae285035bb68d22f9add40fb65dcd5d281e95

commit 8e6ae285035bb68d22f9add40fb65dcd5d281e95
Author: David 'Digit' Turner <digit@google.com>
Date: Fri Oct 26 08:03:51 2018

base: rename trace_event_argument.h to traced_value.h

Since this header, after several refactoring steps, is now only
used to define the TracedValue class, renaming it makes sense.

This CL only updates base/. Note that a forwarding
trace_event_argument.h header is still provided, since a
_lot_ of callers outside of base/ need to be updated before
we can get rid of it.

BUG= 898787 
R=primiano@chromium.org, oysteine@chromium.org, chiniforooshan@chromium.org, nyquist@chromium.org, fdoray@chromium.org

Change-Id: I1156198070353429a6a9933ced3203335d1d874d
Reviewed-on: https://chromium-review.googlesource.com/c/1298955
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603029}
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/BUILD.gn
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/task/sequence_manager/task_queue_selector.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/task/sequence_manager/work_queue.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/task/sequence_manager/work_queue_sets.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/test/test_pending_task.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/test/trace_event_analyzer_unittest.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/blame_context.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/blame_context_unittest.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/memory_allocator_dump.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/memory_allocator_dump.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/memory_allocator_dump_unittest.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/process_memory_dump.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/process_memory_dump_unittest.cc
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/trace_event_argument.h
[modify] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/trace_event_impl.cc
[rename] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/traced_value.cc
[add] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/traced_value.h
[rename] https://crrev.com/8e6ae285035bb68d22f9add40fb65dcd5d281e95/base/trace_event/traced_value_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5c077b840911df9e8b68ba3f2fbd0523e27b48b

commit a5c077b840911df9e8b68ba3f2fbd0523e27b48b
Author: David 'Digit' Turner <digit@google.com>
Date: Fri Oct 26 13:36:38 2018

blink: Use traced_value.h instance of trace_event_argument.h

The header was renamed in a previous CL, this one updates all users
under third_party/blink.

BUG= 898787 
R=skyostil@chromium.org, vollick@chromium.org

Change-Id: I7af7fb328588132e5047e6c60ccec028fe516dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1301436
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603075}
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/graphics/paint/raster_invalidation_tracking.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/instrumentation/tracing/traced_value.h
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/instrumentation/tracing/web_process_memory_dump.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/instrumentation/tracing/web_process_memory_dump_test.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/main_thread/render_widget_signals.h
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/main_thread/user_model.h
[modify] https://crrev.com/a5c077b840911df9e8b68ba3f2fbd0523e27b48b/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0577a79942585ed085f702a5d48a9b31d3f55bc4

commit 0577a79942585ed085f702a5d48a9b31d3f55bc4
Author: David 'Digit' Turner <digit@google.com>
Date: Fri Oct 26 14:32:47 2018

ui: Use traced_value.h instead of trace_event_argument.h

The trace_event_argument.h header was renamed to traced_value.h
in a previous CL, this one updates all includes in //ui/ to use
the new header.

BUG= 898787 
R=sadrul@chromium.org,sky@chromium.org,thakis@chromium.org

Change-Id: I8943695f5764134d2191235ee72a2575b1676607
Reviewed-on: https://chromium-review.googlesource.com/c/1301465
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603084}
[modify] https://crrev.com/0577a79942585ed085f702a5d48a9b31d3f55bc4/ui/latency/frame_metrics.cc
[modify] https://crrev.com/0577a79942585ed085f702a5d48a9b31d3f55bc4/ui/latency/frame_metrics.h
[modify] https://crrev.com/0577a79942585ed085f702a5d48a9b31d3f55bc4/ui/latency/stream_analyzer.h
[modify] https://crrev.com/0577a79942585ed085f702a5d48a9b31d3f55bc4/ui/latency/windowed_analyzer.h
[modify] https://crrev.com/0577a79942585ed085f702a5d48a9b31d3f55bc4/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a874858e014100bad2702ae98e4784f94ee185

commit 59a874858e014100bad2702ae98e4784f94ee185
Author: David 'Digit' Turner <digit@google.com>
Date: Mon Oct 29 13:27:16 2018

cc: Include traced_value.h instead of trace_event_argument.h

The header was renamed in a previous CL, this one adjust all
includes under //cc/ to use the new header instead.

BUG= 898787 
R=skyostil@chromium.org, enne@chromium.org, danakj@chromium.org

Change-Id: I98fafefc6c463c4d5765ef9703fcfdea909ffc2f
Reviewed-on: https://chromium-review.googlesource.com/c/1301464
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603478}
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/animation/animation_host.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/animation/scroll_offset_animations_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/base/devtools_instrumentation.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/base/math_util.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/base/region.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/debug/rendering_stats.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/input/main_thread_scrolling_reason.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/layers/layer_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/paint/display_item_list.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/paint/filter_operation.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/paint/filter_operations.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/scheduler/begin_frame_tracker.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/scheduler/scheduler.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/scheduler/scheduler_settings.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/scheduler/scheduler_state_machine.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/test/mock_layer_client.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/tile.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/tile_draw_info.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/tile_manager.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/tile_priority.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/tiles/tile_priority.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/clip_node.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/clip_node.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/effect_node.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/element_id.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/property_tree.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/proxy_impl.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/proxy_main.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/scroll_node.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/scroll_node.h
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/transform_node.cc
[modify] https://crrev.com/59a874858e014100bad2702ae98e4784f94ee185/cc/trees/transform_node.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea07114f558603e98f25d92dd67b484b16bdfa7c

commit ea07114f558603e98f25d92dd67b484b16bdfa7c
Author: David 'Digit' Turner <digit@google.com>
Date: Mon Oct 29 15:38:12 2018

Replace trace_event_argument.h includes with traced_value.h

trace_event_argument.h was renamed to traced_value.h in a
previous CL (see related bug for all details), so this updates
many includes to use the new header name.

BUG= 898787 
R=torne@chromium.org,nyquist@chromium.org,yfriedman@chromium.org,fdoray@chromium.org,reveman@chromium.org,oshima@chromium.org,jialiu@chromium.org,nparker@chromium.org,battre@chromium.org,primiano@chromium.org,oysteine@chromium.org,danakj@chromium.org,enne@chromium.org,dcheng@chromium.org,backer@chromium.org,ericrk@chromium.org,ben@chromium.org,agl@chromium.org,asanka@chromium.org
TBR=rockot@chromium.org,boliu@chromium.org

Change-Id: I26676db3fa1446a3e007643a6ef58013d0a89357
Reviewed-on: https://chromium-review.googlesource.com/c/1301466
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603502}
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/android_webview/browser/render_thread_manager.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/chrome/browser/android/vr/arcore_device/ar_image_transport.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/chrome/browser/android/vr/gvr_graphics_delegate.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/chrome/browser/android/vr/gvr_scheduler_delegate.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/buffer.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/display.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/shell_surface_base.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/sub_surface.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/exo/surface.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/safe_browsing/db/util.h
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/safe_browsing/db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/content/browser/ruleset_service.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/tracing/test/trace_event_perftest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/frame_sinks/begin_frame_args.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/frame_sinks/begin_frame_source.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/frame_sinks/delay_based_time_source.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/content_draw_quad_base.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/debug_border_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/picture_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/render_pass.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/shared_quad_state.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/solid_color_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/stream_video_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/surface_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/texture_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/tile_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/quads/yuv_video_draw_quad.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/common/traced_value.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/components/viz/test/begin_frame_source_test.h
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/content/browser/frame_host/frame_tree_node_blame_context.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/content/browser/frame_host/frame_tree_node_blame_context_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/content/renderer/frame_blame_context.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/gpu/command_buffer/service/scheduler.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/mojo/core/handle_table_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/net/http/http_cache_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/net/ssl/ssl_client_session_cache_unittest.cc
[modify] https://crrev.com/ea07114f558603e98f25d92dd67b484b16bdfa7c/net/url_request/url_request_quic_perftest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fed33f99a5d2d35067c4cec0759209bfffcdb93

commit 6fed33f99a5d2d35067c4cec0759209bfffcdb93
Author: David 'Digit' Turner <digit@google.com>
Date: Mon Nov 19 16:12:30 2018

Remove last trace_event_argument.h includes.

The header was renamed to traced_value.h since this reflects
which class it really defines. trace_event_argument.h was left
as a forwarding header for those few clients that still depended
on it.

This CL updates these clients to include traced_value.h directly,
and removes trace_event_argument.h

BUG= 898787 
R=primiano@chromium.org, oysteine@chromium.org
TBR=reveman@chromium.org

Change-Id: I5254a95d4f57a2babba97161d793a0774ca35875
Reviewed-on: https://chromium-review.googlesource.com/c/1341544
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609316}
[delete] https://crrev.com/781e6ebd5ddf9dfc15a6c845d2e1831b739c84ee/base/trace_event/trace_event_argument.h
[modify] https://crrev.com/6fed33f99a5d2d35067c4cec0759209bfffcdb93/components/exo/fullscreen_shell_surface.cc
[modify] https://crrev.com/6fed33f99a5d2d35067c4cec0759209bfffcdb93/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
[modify] https://crrev.com/6fed33f99a5d2d35067c4cec0759209bfffcdb93/services/tracing/public/cpp/perfetto/traced_value_proto_writer.cc
[modify] https://crrev.com/6fed33f99a5d2d35067c4cec0759209bfffcdb93/services/tracing/public/cpp/perfetto/traced_value_proto_writer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment