New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898786 link

Starred by 2 users
Status: Fixed
Owner:
█ rsgingerrs@chromium.org
Last visit 20 days ago
Closed: Dec 5
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Favicon image is not seen properly on 'Manage search engine' page.

Reported by dchau...@etouch.net, Oct 25 
Chrome Version: 72.0.3590.0 (Official Build)Revision ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1} (32/64 Bit).
OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTS). 

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://settings/searchEngines page.
2. Click on 'more actions' icon of any search engine and select 'Edit' option to open 'Edit search engine' overlay.
3. Now enter any long text in 'Search engine' text-box, click on 'Save' button and observe the favicon image.

Actual: Favicon image is not seen properly for corresponding search engine.
Expected: Favicon image should seen for corresponding search engine.

This is a regression issue, broken in M-72 series, will soon update bisect info.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
663 KB View Download
Expected behavior.mp4
661 KB View Download

Comment 1 by dchau...@etouch.net, Oct 25

Labels: hasbisect
Owner: rsgingerrs@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range:

Good build: 72.0.3589.0 (Revision: 601811)
Bad build: 72.0.3590.0 (Revision: 602167)

You are probably looking for a change made after 602092 (known good), but no later than 602099 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b6e27eb1610461f0f956e8d92a9502a66350769c..4cb312703d70ef1fd7f4379d971ff848b5977b8a

Suspecting: https://chromium.googlesource.com/chromium/src/+/4cb312703d70ef1fd7f4379d971ff848b5977b8a

@rsgingerrs: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.

Thank you.

Comment 2 by dpa...@chromium.org, Oct 25 

@rsgingerrs: It seems that the introduction of site-favicon regressed the min-width of the favicon, see video.

Comment 3 by rsgingerrs@chromium.org, Oct 25 

Sorry about that. Have sent out a CL to fix it.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffcb158d35dc3f4ce5cb70b31353ba6fa9b62d46

commit ffcb158d35dc3f4ce5cb70b31353ba6fa9b62d46
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Oct 25 22:23:55 2018

[Settings] Fix a bug that favicon is not seen properly on searchEngines

Bug:  898786 
Change-Id: I83f38fb6c9a9471793f0faadaee619a9771eb7ce
Reviewed-on: https://chromium-review.googlesource.com/c/1299521
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602897}
[modify] https://crrev.com/ffcb158d35dc3f4ce5cb70b31353ba6fa9b62d46/chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html

Comment 5 by dchau...@etouch.net, Oct 26

Labels: TE-Verified-M72 TE-Verified-72.0.3592.0
Update:
Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14) and Linux(14.04) machines using latest Canary #72.0.3592.0 and issue is fixed. Hence adding TE-Verified labels.

please refer the attached screen-cast for reference.

Thank you.
Fixed behavior.mp4
592 KB View Download

Comment 6 by dpa...@chromium.org, Dec 5

Status: Fixed (was: Assigned)
Assuming this is fixed?
►

Sign in to add a comment