security.MountSymlink failing on guado_moblab |
|||
Issue descriptionsecurity.MountSymlink is consistently failing on guado_moblab: https://stainless.corp.google.com/search?view=list&first_date=2018-10-19&last_date=2018-10-25&master_builder_name=master-release&branch=master&test=^tast\.security\.MountSymlink%24&status=FAIL&status=ERROR&status=ABORT&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false It's a test ported from security_ChromiumOSLSM autotest. https://cs.corp.google.com/chromeos_public/src/platform/tast-tests/src/chromiumos/tast/local/bundles/cros/security/mount_symlink.go?q=MountSymlink&g=0&l=24 I guess the security feature is not enabled on moblab boards? Security team, could you confirm?
,
Nov 6
It is switched off for any builds that use LXC - and moblab uses LXC containers for server side tests. https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/eclass/cros-kernel2.eclass?rcl=e15357a4658fde304fe3fcdd33a269fdb3e3761e&l=771
,
Nov 14
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a4fa2b4608ebe23e23600ea1f9f60e437540261 commit 8a4fa2b4608ebe23e23600ea1f9f60e437540261 Author: Daniel Erat <derat@chromium.org> Date: Fri Nov 16 13:01:40 2018 tast-use-flags: Add lxc to IUSE. Add the lxc USE flag to IUSE so it can be used to inform a new no_symlink_mount feature/dependency. BUG= chromium:898781 TEST=none Change-Id: If5e9ab03c980f77c29a2a471585fb1745ba2c30a Reviewed-on: https://chromium-review.googlesource.com/1335251 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/8a4fa2b4608ebe23e23600ea1f9f60e437540261/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r13.ebuild [modify] https://crrev.com/8a4fa2b4608ebe23e23600ea1f9f60e437540261/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/20b83967c4d49be622177d568c6d63ac1a13de34 commit 20b83967c4d49be622177d568c6d63ac1a13de34 Author: Daniel Erat <derat@chromium.org> Date: Fri Nov 16 13:01:41 2018 tast-tests: Make security.MountSymlink use no_symlink_mount. Make the security.MountSymlink test depend on a new no_symlink_mount feature. This is needed to avoid running on guado_moblab (and any other boards that set the "lxc" USE flag), which causes the CONFIG_SECURITY_CHROMIUMOS_NO_SYMLINK_MOUNT kernel option to be disabled. BUG= chromium:898781 TEST=checked that test is skipped on guado_moblab CQ-DEPEND=Ib9f4a0a16a4ad85be0ee2d9c931fc59da3962f0d Change-Id: Iaf74864f9510b7d241f899c25019f169bb1ab571 Reviewed-on: https://chromium-review.googlesource.com/1335175 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/20b83967c4d49be622177d568c6d63ac1a13de34/src/chromiumos/tast/local/bundles/cros/security/mount_symlink.go
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/97478888a30a7f85c51a33758d350c7422b9996b commit 97478888a30a7f85c51a33758d350c7422b9996b Author: Daniel Erat <derat@chromium.org> Date: Fri Nov 16 13:01:40 2018 tast: Add a new "no_symlink_mount" software feature. Add a "no_symlink_mount" software feature that tests can depend on to ensure that the CONFIG_SECURITY_CHROMIUMOS_NO_SYMLINK_MOUNT kernel setting is enabled. BUG= chromium:898781 TEST=added lxc to tast_use_flags.txt and checked that test that depends on no_symlink_mount is skipped CQ-DEPEND=If5e9ab03c980f77c29a2a471585fb1745ba2c30a Change-Id: Ib9f4a0a16a4ad85be0ee2d9c931fc59da3962f0d Reviewed-on: https://chromium-review.googlesource.com/1334976 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/97478888a30a7f85c51a33758d350c7422b9996b/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/97478888a30a7f85c51a33758d350c7422b9996b/docs/test_dependencies.md
,
Nov 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nya@chromium.org
, Oct 31