Issue metadata
Sign in to add a comment
|
Regression : No space is seen between 'Add word' button and 'Add a new word' text field in chrome://settings/languages.
Reported by
rp...@etouch.net,
Oct 25
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3590.0 (Official Build)Revision ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1}(32/64-bit) OS: Win(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/languages 2. Click to expand 'Spell check' and click on 'Custom spelling' and observe 'Add word' button Actual Result: No space is seen between 'Add word' button and 'Add a new word' text field Expected Result: Proper space should be seen between 'Add word' button and 'Add a new word' text field This is a regression issue, broken in M-72, and below is the bisect info. Good Build:72.0.3583.0 (Revision:600164) Bad Build: 72.0.3584.0 (Revision:600616) You are probably looking for a change made after 600224 (known good), but no later than 600228 (first known bad). Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/62f2f8f209a82db0dd5a311eb4f844bddb75c98e..631a939b2b9a02a05cd1db367c7ea7fb17d14f50?pretty=fuller&n=10000 Suspect: r600225 ? dpapad@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script. 2.Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error. 3.Issue is not seen on Mac(10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTS). Thank You!
,
Oct 27
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59367a52a3bd5287586b5c95c7cdbd94b724b74e commit 59367a52a3bd5287586b5c95c7cdbd94b724b74e Author: dpapad <dpapad@chromium.org> Date: Tue Oct 30 03:00:09 2018 WebUI cr-input: Fix style of slotted paper-button with Shadow DOM v1. Bug: 898763 Change-Id: Iff586501573beaea6ddf8e6ea9d9e5675f480bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1303403 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603750} [modify] https://crrev.com/59367a52a3bd5287586b5c95c7cdbd94b724b74e/ui/webui/resources/cr_elements/cr_input/cr_input.html
,
Oct 30
,
Nov 1
Update : Rechecked the above issue on Windows (7,8,8.1,10) using latest Canary build : 72.0.3598.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Oct 25Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)