New issue
Advanced search Search tips

Issue 898747 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Oct 25
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: LocalCardMigrationBrowserTest.AllCardsVisibleOnDialog



Sign in to add a comment

LocalCardMigrationBrowserTest.AllCardsVisibleOnDialog is flaky

Project Member Reported by Findit, Oct 25

Issue description


Flaky test: LocalCardMigrationBrowserTest.AllCardsVisibleOnDialog
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4415
Test output log: https://chromium-swarm.appspot.com/task?id=40c21537577ae210
Culprit (100.0% confidence): r602564
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKbAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDQxNS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVEc5allXeERZWEprVFdsbmNtRjBhVzl1UW5KdmQzTmxjbFJsYzNRdVFXeHNRMkZ5WkhOV2FYTnBZbXhsVDI1RWFXRnNiMmM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20LocalCardMigrationBrowserTest.AllCardsVisibleOnDialog&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKbAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvNDQxNS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVEc5allXeERZWEprVFdsbmNtRjBhVzl1UW5KdmQzTmxjbFJsYzNRdVFXeHNRMkZ5WkhOV2FYTnBZbXhsVDI1RWFXRnNiMmM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c578a3c50abb618728841c34c86dc9cc54fc3d

commit 58c578a3c50abb618728841c34c86dc9cc54fc3d
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Oct 25 04:04:46 2018

Revert "[Autofill] Added browser tests for local card migration dialog."

This reverts commit 156cf965c7e1544ab17531b129953d9e99b6b80b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 602564 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMTU2Y2Y5NjVjN2UxNTQ0YWIxNzUzMWIxMjk5NTNkOWU5OWI2YjgwYgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4415

Sample Failed Step: network_service_browser_tests on Ubuntu-16.04

Sample Flaky Test: LocalCardMigrationBrowserTest.AllCardsVisibleOnDialog

Original change's description:
> [Autofill] Added browser tests for local card migration dialog.
> 
> Browser tests for the main migration dialog, the intermediate offer bubble, and migration metrics.
> 
> Bug: 897998
> Change-Id: I86c185d589e3e74bd7fe2d46ff80d26eae3f4733
> Reviewed-on: https://chromium-review.googlesource.com/c/1255634
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#602564}

Change-Id: Ief01be286bc6a1fa03bcec98070b28b80de2c2d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897998,  898747 
Reviewed-on: https://chromium-review.googlesource.com/c/1298652
Cr-Commit-Position: refs/heads/master@{#602605}
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/views/autofill/dialog_view_ids.h
[delete] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/ui/views/autofill/local_card_migration_browsertest.cc
[delete] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/ui/views/autofill/local_card_migration_browsertest_base.cc
[delete] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/ui/views/autofill/local_card_migration_browsertest_base.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/chrome/test/BUILD.gn
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/components/autofill/core/browser/form_data_importer.h
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/components/autofill/core/browser/local_card_migration_manager.cc
[modify] https://crrev.com/58c578a3c50abb618728841c34c86dc9cc54fc3d/components/autofill/core/browser/local_card_migration_manager.h

Labels: -Sheriff-Chromium
Mergedinto: 897998
Status: Duplicate (was: Untriaged)

Sign in to add a comment