New issue
Advanced search Search tips

Issue 898742 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: ----



Sign in to add a comment

DesktopWindowTreeHostX11Test.Shape flaky

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 25

Issue description

Test has been flaky for a while.
Screenshot from 2018-10-25 14-23-07.png
236 KB View Download
Components: Internals>Views
Labels: OS-Linux
Failure output:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931735058821978848/+/steps/views_unittests_on_Ubuntu-16.04/0/logs/DesktopWindowTreeHostX11Test.Shape/0

[  FAILED  ] DesktopWindowTreeHostX11Test.Shape (60 ms)
[ RUN      ] DesktopWindowTreeHostX11Test.Shape
../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc:212: Failure
Value of: ShapeRectContainsPoint(shape_rects, widget_width - 5, 5)
  Actual: true
Expected: false
Stack trace:
#0 0x000000b3f05c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x000000b3ea29 testing::internal::AssertHelper::operator=()
#2 0x00000061c562 views::DesktopWindowTreeHostX11Test_Shape_Test::TestBody()

[  FAILED  ] DesktopWindowTreeHostX11Test.Shape (53 ms)
Labels: -Sheriff-Chromium
Owner: pkotw...@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feacf7db39217943218baa3fdc690f831da512f2

commit feacf7db39217943218baa3fdc690f831da512f2
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Oct 25 04:10:48 2018

Disable DesktopWindowTreeHostX11Test.Shape due to flakiness

DesktopWindowTreeHostX11Test.Shape fails every other run.

TBR=pkotwicz
NOTRY=TRUE

Bug: 898742
Change-Id: Ia6874fee0915abd7341330659cab0cc6d7159156
Reviewed-on: https://chromium-review.googlesource.com/c/1297859
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602607}
[modify] https://crrev.com/feacf7db39217943218baa3fdc690f831da512f2/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28ccfac662712d2b4681286bb210cc75cfcbf971

commit 28ccfac662712d2b4681286bb210cc75cfcbf971
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Oct 25 04:27:29 2018

Revert "Disable DesktopWindowTreeHostX11Test.Shape due to flakiness"

This reverts commit feacf7db39217943218baa3fdc690f831da512f2.

Reason for revert: 
Causes tree close because of compile failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931724411571019664/+/steps/compile/0/stdout
TEST_F(DISABLED_DesktopWindowTreeHostX11Test, Shape) {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       DesktopWindowTreeHostX11Test
../../third_party/googletest/src/googletest/include/gtest/gtest.h:2309:40: note: expanded from macro 'TEST_F'
  GTEST_TEST_(test_fixture, test_name, test_fixture, \
                                       ^

Original change's description:
> Disable DesktopWindowTreeHostX11Test.Shape due to flakiness
> 
> DesktopWindowTreeHostX11Test.Shape fails every other run.
> 
> TBR=pkotwicz
> NOTRY=TRUE
> 
> Bug: 898742
> Change-Id: Ia6874fee0915abd7341330659cab0cc6d7159156
> Reviewed-on: https://chromium-review.googlesource.com/c/1297859
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602607}

TBR=alancutter@chromium.org

Change-Id: Ifc988c06391c69cee8bcc5c2d28813ba8c6e78b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898742
Reviewed-on: https://chromium-review.googlesource.com/c/1298522
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#602610}
[modify] https://crrev.com/28ccfac662712d2b4681286bb210cc75cfcbf971/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb8c836a4382865663c5191b2c34e2738af67db

commit 9fb8c836a4382865663c5191b2c34e2738af67db
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Oct 25 05:00:23 2018

Reland "Disable DesktopWindowTreeHostX11Test.Shape due to flakiness"

This is a reland of feacf7db39217943218baa3fdc690f831da512f2

Original change's description:
> Disable DesktopWindowTreeHostX11Test.Shape due to flakiness
>
> DesktopWindowTreeHostX11Test.Shape fails every other run.
>
> TBR=pkotwicz
> NOTRY=TRUE
>
> Bug: 898742
> Change-Id: Ia6874fee0915abd7341330659cab0cc6d7159156
> Reviewed-on: https://chromium-review.googlesource.com/c/1297859
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602607}

TBR=pkotwicz@chromium.org

Bug: 898742
Change-Id: I6de9d80dfefdd68e32fa36989eaa585fdea13ef9
Reviewed-on: https://chromium-review.googlesource.com/c/1298525
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602615}
[modify] https://crrev.com/9fb8c836a4382865663c5191b2c34e2738af67db/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc

Cc: ligim...@chromium.org
Labels: Hotlist-DesktopUIChecked
*** UI Mass Triage ***

Since there is not updates in the past few weeks, closing.

If this bug still reproduces for you, please reopen or file a new issue. Thanks!

Sign in to add a comment