New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Autofill save card bubble legal message clicking is not correctly logged.

Project Member Reported by siyua@chromium.org, Oct 25

Issue description

The UMA logging is not correctly set after moving legal message view to util.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641825931a6216869ffa3e9c22b56d0559cc8850

commit 641825931a6216869ffa3e9c22b56d0559cc8850
Author: siyua <siyua@chromium.org>
Date: Fri Oct 26 23:00:42 2018

Fix save card bubble legal message clicking metrics logging.

The logic was moved to a legal message view class in the view_util.*,
and when removing, metrics logging was not correctly set.

Bug:  898724 
Change-Id: I8f285b61003a49cdc884641a9ff526b1760abcb0
Reviewed-on: https://chromium-review.googlesource.com/c/1298713
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603239}
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/local_card_migration_offer_view.cc
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/local_card_migration_offer_view.h
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/view_util.cc
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/chrome/browser/ui/views/autofill/view_util.h
[modify] https://crrev.com/641825931a6216869ffa3e9c22b56d0559cc8850/components/autofill/core/browser/ui/local_card_migration_dialog_controller.h

Status: Fixed (was: Assigned)

Sign in to add a comment