Nothing in ChromePasswordProtectionService::IsHistorySyncEnabled() looks off to me. My guess is that Sync maybe just hasn't finished initializing yet?

Can you post a screenshot of chrome://sync-internals while in this state?

Ok, I can't repro the "sync on/of/on -- ISSE() == false" behavior at ToT anymore (72.0.3603.0 linux). I don't know what changed.  But, I can repro this related issue:

1) Turn on sync
2) Sign out of content area -- sync gets paused.
3) IsHistorySyncEnabled() still returns true, even though the events aren't getting synced.


I've attached sync-internals for that state.

Deleted: cr-sync-int -- Screenshot from 2018-11-05 13-16-05.png 348 KB

	cr-sync-int -- Screenshot from 2018-11-05 13-16-05.png 348 KB View Download

That is expected, and just goes to show (again) how the question "is Sync on?" is much more nuanced than it should be...

In the "paused" state, Sync is technically still on. I.e. local changes are tracked, and will get uploaded (without any further opt-in/consent/etc) once the user signs in again.

If you want to know if we're actually actively uploading stuff right now, take a look at syncer::GetUploadToGoogleState().