The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9

commit 0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9
Author: Kevin Strohbehn <ginko@google.com>
Date: Fri Oct 26 00:04:37 2018

Makes wallpaper dim in tablet mode, without relying on app_list_shield

Bug:  898712 
Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8
Reviewed-on: https://chromium-review.googlesource.com/c/1298507
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#602938}
[modify] https://crrev.com/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9/ash/wallpaper/wallpaper_view.h
[modify] https://crrev.com/0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9/ash/wm/overview/window_grid.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28

commit f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28
Author: Takashi Sakamoto <tasak@google.com>
Date: Fri Oct 26 05:03:15 2018

Revert "Makes wallpaper dim in tablet mode, without relying on app_list_shield"

This reverts commit 0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9.

Reason for revert: 
Suspect Linux ChromiumOS MSan Tests failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9258

One of error logs:
[ RUN      ] LockStateControllerTest.LockButtonBasicGuest
==6821==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000005c58 at pc 0x000007937b9c bp 0x7ffdd8818530 sp 0x7ffdd8818528
READ of size 8 at 0x616000005c58 thread T0
    #0 0x7937b9b in begin buildtools/third_party/libc++/trunk/include/vector:1506:30
    #1 0x7937b9b in base::ObserverList<ash::TabletModeObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(ash::TabletModeObserver const*) base/observer_list.h:282
    #2 0x73376c6 in RemoveAll base/scoped_observer.h:45:20
    #3 0x73376c6 in ScopedObserver<ash::TabletModeController, ash::TabletModeObserver>::~ScopedObserver() base/scoped_observer.h:26
    #4 0x7889542 in ~WallpaperView ash/wallpaper/wallpaper_view.cc:150:1
    #5 0x7889542 in ash::WallpaperView::~WallpaperView() ash/wallpaper/wallpaper_view.cc:148
    #6 0x9a96a66 in views::View::~View() ui/views/view.cc:162:9
    #7 0x788c19d in ash::(anonymous namespace)::LayerControlView::~LayerControlView() ash/wallpaper/wallpaper_view.cc:43:7
    #8 0x9a9b800 in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5
    #9 0x9a9b800 in reset buildtools/third_party/libc++/trunk/include/memory:2638
    #10 0x9a9b800 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592
    #11 0x9a9b800 in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:2053
    #12 0x9a9d418 in views::View::RemoveAllChildViews(bool) ui/views/view.cc:300:5
    #13 0x9ac9585 in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:183:5
    #14 0x9ac973d in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:179:23
    #15 0x9ad351b in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5
    #16 0x9ad351b in reset buildtools/third_party/libc++/trunk/include/memory:2638
    #17 0x9ad351b in DestroyRootView ui/views/widget/widget.cc:1456
    #18 0x9ad351b in views::Widget::~Widget() ui/views/widget/widget.cc:187
    #19 0x9ad455d in views::Widget::~Widget() ui/views/widget/widget.cc:186:19
    #20 0x9b2bb12 in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc
    #21 0x9b2bdad in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc:1034:39
    #22 0x95945c5 in aura::Window::~Window() ui/aura/window.cc:139:16
    #23 0x95960ad in aura::Window::~Window() ui/aura/window.cc:94:19

Original change's description:
> Makes wallpaper dim in tablet mode, without relying on app_list_shield
> 
> Bug:  898712 
> Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/1298507
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Kevin Strohbehn <ginko@google.com>
> Cr-Commit-Position: refs/heads/master@{#602938}

TBR=xiyuan@chromium.org,weidongg@chromium.org,ginko@google.com

Change-Id: I86dbf4da685e23e5106ac7a778e665729581e0ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  898712 
Reviewed-on: https://chromium-review.googlesource.com/c/1301035
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#602991}
[modify] https://crrev.com/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28/ash/wallpaper/wallpaper_view.h
[modify] https://crrev.com/f8ab889cccedf7c5ba8133a2b9f267cd4a7d3a28/ash/wm/overview/window_grid.cc

See  bug 899158 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f134abefe58874b15d44caf07d0e3f3fb39ec9

commit e6f134abefe58874b15d44caf07d0e3f3fb39ec9
Author: Kevin Strohbehn <ginko@google.com>
Date: Mon Oct 29 20:23:24 2018

Reland "Makes wallpaper dim in tablet mode, without relying on app_list_shield"

This is a reland of 0b1076357bef0f7fe024b66e64f6c4ec1cb2c1b9

Includes changes to fix MSAN issues

Bug:  898712 ,  899158 

Original change's description:
> Makes wallpaper dim in tablet mode, without relying on app_list_shield
>
> Bug:  898712 
> Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/1298507
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Kevin Strohbehn <ginko@google.com>
> Cr-Commit-Position: refs/heads/master@{#602938}

Bug:  898712 
Change-Id: Ief534b6dc58b5d36b3f96952141a51312c50a79f
Reviewed-on: https://chromium-review.googlesource.com/c/1303233
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603605}
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wallpaper/wallpaper_view.h
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wm/overview/window_grid.h
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/e6f134abefe58874b15d44caf07d0e3f3fb39ec9/ash/wm/tablet_mode/tablet_mode_observer.h

Per the M71 Branch Announcement: "Have your change checked into the trunk, and tested by you on either a Canary build or Dev channel release before asking for merge approval."   Has this testing taken place?  If so, results?  If not, please test prior to the merge request.  Esp. since this impacts so many areas.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I'll let this hit canary along with another bug, and then I'll test all of them together to make sure they still work. It seems solid on ToT but it is definitely 4 weeks in and the bar needs to be very high, so I'll make sure to wait for a canary build. I'll be testing this along with  https://crbug.com/896790 

Sorry for not having all this done before: I didn't notice the announcement.

How did testing go on this? Thanks.

Ping

It works as expected in 72 canary!

Merge Approved for ChromeOS M71

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot