New issue
Advanced search Search tips

Issue 898697 link

Starred by 1 user
Status: Fixed
Owner:
mrefaat@chromium.org
Closed: Nov 30
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
q4



Sign in to add a comment

Move isVoiceSearchResultsTab out of tab

Project Member Reported by mrefaat@chromium.org, Oct 24 
isVoiceSearchResultsTab can either be put to TabUtilities or moved to voiceSearch specific file

Comment 1 by mrefaat@chromium.org, Oct 25

Labels: -ios-tab-refactoring-tab-utilities ios-tab-refactoring O-ios-tab-utilities S-ios-convert-to-tab-util

Comment 2 by mrefaat@google.com, Nov 28

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eea2e46ea1df609f21ab9169d1bafe9e709436d

commit 3eea2e46ea1df609f21ab9169d1bafe9e709436d
Author: mrefaat <mrefaat@chromium.org>
Date: Wed Nov 28 22:53:58 2018

Remove isVoiceSearchResultsTab from tab

This was created for voicesearch bar which is removed with the new UI.

Bug:  898697 ,  778416 
Change-Id: Ice43ef892a886bf616f8bc2712c0a6b2d48b29f8
Reviewed-on: https://chromium-review.googlesource.com/c/1353936
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611914}
[modify] https://crrev.com/3eea2e46ea1df609f21ab9169d1bafe9e709436d/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/3eea2e46ea1df609f21ab9169d1bafe9e709436d/ios/chrome/browser/tabs/tab.mm

Comment 4 by mrefaat@google.com, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment