New issue
Advanced search Search tips

Issue 898688 link

Starred by 2 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Oct 31
Cc:
iclell...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

vertical-scroll should not affect view-source: page.

Project Member Reported by ericbidelman@chromium.org, Oct 24 
Chrome Version: 72.0.3590.0 (Official Build) canary (64-bit)
OS: macosx

What steps will reproduce the problem?
(1) Visit view-source:https://20181024t224456-dot-chromedevsummit-site.appspot.com/devsummit/schedule

What is the expected result?

You can scroll the page. 

What happens instead?

The page is not scrollable. The main page sends `vertical-scroll 'none'`, but this should not affect view-source

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by ekaramad@chromium.org, Oct 25

Cc: iclell...@chromium.org
Status: Assigned (was: Untriaged)
I can reproduce this. Thanks for reporting.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a2cadf8e169b2aba6fff00000e8776050d199b

commit c1a2cadf8e169b2aba6fff00000e8776050d199b
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Wed Oct 31 15:07:09 2018

HTMLViewSourceDocument not affected by Feature-Policy

Feature-Policy does not quite make sense in a view-source document; such documents are not actually
rendering "the" WebPage. This CL makes sure feature policy takes the default values for a
view-source document.

TBR=iclelland@chromium.org

Bug:  898688 
Change-Id: I4f8667f8539da977d0cf0281f4e8ee99fe9b23e9
Reviewed-on: https://chromium-review.googlesource.com/c/1305248
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604256}
[modify] https://crrev.com/c1a2cadf8e169b2aba6fff00000e8776050d199b/chrome/browser/tab_contents/view_source_browsertest.cc
[add] https://crrev.com/c1a2cadf8e169b2aba6fff00000e8776050d199b/chrome/test/data/viewsource/test.html.mock-http-headers
[modify] https://crrev.com/c1a2cadf8e169b2aba6fff00000e8776050d199b/third_party/blink/renderer/core/execution_context/security_context.cc
[modify] https://crrev.com/c1a2cadf8e169b2aba6fff00000e8776050d199b/third_party/blink/renderer/core/execution_context/security_context.h
[modify] https://crrev.com/c1a2cadf8e169b2aba6fff00000e8776050d199b/third_party/blink/renderer/core/html/html_view_source_document.h

Comment 3 by ekaramad@chromium.org, Oct 31

Status: Fixed (was: Assigned)
As @604256 no feature policy state is propagated to "view-source" documents. Marking as fixed.
►

Sign in to add a comment