New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898667 link

Starred by 1 user
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Nov 26
Cc:
pastarmovj@chromium.org
█ goanuj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocked on:
issue 887005
Blocking:
issue 914423



Sign in to add a comment

gather BrowserSwitcher / LBS metrics

Project Member Reported by goanuj@chromium.org, Oct 24 
See Chrome Browserswitcher PRD (Metrics)

LBS.OpenURL [Win7=1, Win10=2, other=3]
LBS.ListSize [int]
LBS.DecisionTime [int]
LBS.TransitionWindowTime [int]
LBS.GrayListWildCard [yes=1, no=0] … find out if users predominantly prefer IE vs. predominantly prefer Chrome
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53c85af96e7e3069a5b913b84299dcccbc7b5b6a

commit 53c85af96e7e3069a5b913b84299dcccbc7b5b6a
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Mon Nov 26 22:05:47 2018

[BrowserSwitcher] Add metrics

This adds a handful of metrics:
- Number of navigations that trigger a switch
- Number of rules are in the various sitelists
- Time it takes to make a decision, on navigation
- Time it takes to start the alternate browser
- Success rate for alternate browser launch
- Whether the UrlList policy contains a wildcard

Bug:  898667 
Change-Id: Ibc3d3d40725dcb84c685a9e59e3b28cd79ce860e
Reviewed-on: https://chromium-review.googlesource.com/c/1333872
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610956}
[modify] https://crrev.com/53c85af96e7e3069a5b913b84299dcccbc7b5b6a/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[modify] https://crrev.com/53c85af96e7e3069a5b913b84299dcccbc7b5b6a/chrome/browser/browser_switcher/browser_switcher_sitelist.cc
[modify] https://crrev.com/53c85af96e7e3069a5b913b84299dcccbc7b5b6a/chrome/browser/browser_switcher/browser_switcher_sitelist.h
[modify] https://crrev.com/53c85af96e7e3069a5b913b84299dcccbc7b5b6a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/53c85af96e7e3069a5b913b84299dcccbc7b5b6a/tools/metrics/histograms/histograms.xml

Comment 2 by nicolaso@chromium.org, Nov 26

Status: Fixed (was: Unconfirmed)
goanuj@, I believe this covers all the metrics we talked about. The histograms are:

- BrowserSwitcher.Decision (bool: false=stay, true=switch)
- BrowserSwitcher.{ExternalSitelist,Greylist,IeemSitelist,UrlList}Size (int)
- BrowserSwitcher.{Greylist,UrlList}Wildcard (bool, true=contains wildcard)
- BrowserSwitcher.LaunchSuccess (bool, true=success)
- BrowserSwitcher.LaunchTime (timer)
- BrowserSwitcher.DecisionTime (timer)

Please mark this 'Verified' if that covers it, or re-open if I missed something.

Comment 3 by goanuj@google.com, Dec 19

Status: Verified (was: Fixed)
►

Sign in to add a comment