[Merge Request M71] Update migration bubble upon privacy request |
|||||||
Issue descriptionRequesting to merge the CL updating the text message of migration bubble. https://chromium-review.googlesource.com/c/chromium/src/+/1294722 https://chromium-review.googlesource.com/c/chromium/src/+/1298083 These CLs only update the text shown in the migration bubble. They have not touched files outside the scope of project Paradise. This is a privacy launch blocker for the project. The second CL is a quick follow-up for the first one resolving one comment for a reviewer. Thanks!
,
Oct 25
Pls update bug with canary result tomorrow.
,
Oct 25
The NextAction date has arrived: 2018-10-25
,
Oct 25
How are the change looking canary?
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25
Approving merge to M71 branch 3578 based on comments #0, #6 and per internal mail thread. Pls merge ASAP. Thank you.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea05de2faf5e114dc748b8b269425015a057d8f Commit: 3ea05de2faf5e114dc748b8b269425015a057d8f Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-10-25 16:47:49 +0000 UTC Update the local card migration bubble upon privacy request (F Option) Changed the title, and added a body text. Uploaded a screenshot in the bug. Note that the body text color is incorrect (should be Google Grey 700) due to crbug.com/896891 . Bug: 898662 Change-Id: I5bf1cf07c6c86bb5a985811485edcb61d14d2610 Reviewed-on: https://chromium-review.googlesource.com/c/1294722 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602451}(cherry picked from commit 573604e22396782df6023dad6ff386a98d2bdf97) Reviewed-on: https://chromium-review.googlesource.com/c/1299541 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#324} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea05de2faf5e114dc748b8b269425015a057d8f commit 3ea05de2faf5e114dc748b8b269425015a057d8f Author: siyua <siyua@chromium.org> Date: Thu Oct 25 16:47:49 2018 Update the local card migration bubble upon privacy request (F Option) Changed the title, and added a body text. Uploaded a screenshot in the bug. Note that the body text color is incorrect (should be Google Grey 700) due to crbug.com/896891 . Bug: 898662 Change-Id: I5bf1cf07c6c86bb5a985811485edcb61d14d2610 Reviewed-on: https://chromium-review.googlesource.com/c/1294722 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602451}(cherry picked from commit 573604e22396782df6023dad6ff386a98d2bdf97) Reviewed-on: https://chromium-review.googlesource.com/c/1299541 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#324} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3ea05de2faf5e114dc748b8b269425015a057d8f/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc [modify] https://crrev.com/3ea05de2faf5e114dc748b8b269425015a057d8f/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h [modify] https://crrev.com/3ea05de2faf5e114dc748b8b269425015a057d8f/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc [modify] https://crrev.com/3ea05de2faf5e114dc748b8b269425015a057d8f/components/autofill/core/browser/ui/local_card_migration_bubble_controller.h [modify] https://crrev.com/3ea05de2faf5e114dc748b8b269425015a057d8f/components/autofill_strings.grdp
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237c0908382b0b6c39689bb51643bf6660739bc8 commit 237c0908382b0b6c39689bb51643bf6660739bc8 Author: siyua <siyua@chromium.org> Date: Thu Oct 25 16:48:28 2018 Moved the title of migration bubble from body to title container. Bug: 898662 Change-Id: I39e0595288a4d9441fc2452b2d47b4f430a4d0cb Reviewed-on: https://chromium-review.googlesource.com/c/1298083 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602527}(cherry picked from commit b1405602455dfaeab4b96ef56836fe5d7525a7b5) Reviewed-on: https://chromium-review.googlesource.com/c/1299542 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#325} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/237c0908382b0b6c39689bb51643bf6660739bc8/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
,
Oct 25
Both merges complete; marking as fixed.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237c0908382b0b6c39689bb51643bf6660739bc8 Commit: 237c0908382b0b6c39689bb51643bf6660739bc8 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-10-25 16:48:28 +0000 UTC Moved the title of migration bubble from body to title container. Bug: 898662 Change-Id: I39e0595288a4d9441fc2452b2d47b4f430a4d0cb Reviewed-on: https://chromium-review.googlesource.com/c/1298083 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602527}(cherry picked from commit b1405602455dfaeab4b96ef56836fe5d7525a7b5) Reviewed-on: https://chromium-review.googlesource.com/c/1299542 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#325} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 26
Is CL listed at #12 need a merge to M71?
,
Oct 26
Re comment #13: Yes, the second CL is actually part of the first one. When submitted the first one, I left out one comment. So I made this change in the second CL in comment#12. This change is required by the code owner.
,
Oct 26
Got it, and it is already merged to M71 so no further merge is needed, correct?
,
Oct 26
Correct, confirm this issue is resolved. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by siyua@chromium.org
, Oct 24