New issue
Advanced search Search tips

Issue 898660 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 898261



Sign in to add a comment

Add an option to transitively include annotation processor for java library deps.

Project Member Reported by estevenson@chromium.org, Oct 24

Issue description

Right now, to use the new JNI annotations you need to add two deps:
deps = ["//base:jni_processor_annotations_java"]
annotation_processor_deps = [ "//base/android/jni_generator:jni_processor" ]

We could make this simpler by adding an option to the java_library template that'll cause dependent java targets to run the processor. Ex:

// All targets that depend on this will now run the jni processor at compile time. 
android_library("jni_processor_annotations_java") {
  exported_annotation_processor_deps = "//base/android/jni_generator:jni_processor"
  ...
}
 
I think it's reasonable to add annotation_processor_deps = ... to each target. Makes it clear what extra magic is happening on that target.


The extra dep is maybe a bit unfortunate though. We could either:
1. Make it so that annotation processors can add to the target's classpath, or
2. Make base_java a group that exposes both base_core_java and jni_processor_annotations_java.


Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99e905516a43b083f57672a256aade7cb09b872

commit c99e905516a43b083f57672a256aade7cb09b872
Author: Aiden Benner <abenner@google.com>
Date: Fri Nov 30 20:50:50 2018

JNI: Remove jclass from JNI static methods

MASS REFACTOR - please consider fixing rather than reverting.

The jclass parameter is never used in static JNI functions because we generate
bindings ourselves for functions that are called by native.

This CL removes the jclass parameter from all JNI methods by refactoring all current
JNI method declarations that contain a jclass and stops the JNI generator
from generating stubs that pass jclass to our implementation.

This change is also being done to support the conversion of all non-static native
methods to static native methods and then all static natives to the new JNI interface.
When this is done proguard will be able to obfuscate classes that contain native methods.
And native methods that don't rely on native

TBR=agrieve # wide-reaching mechanical refactor

Bug: 898660
Change-Id: Ie2932564d58933a2f4bcd23fe47723e147cf87d8
Reviewed-on: https://chromium-review.googlesource.com/c/1352518
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612772}
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/android_protocol_handler.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_debug.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_feature_list.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_form_database.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_gl_functor.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/android_webview/test/embedded_test_server/aw_embedded_test_server.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/application_status_listener.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/child_process_service.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/command_line_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/cpu_features.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/early_trace_event_binding.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/field_trial_list.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/important_file_writer_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/java_exception_reporter.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/HashedSampleForAnnotationProcessor_jni.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/SampleForAnnotationProcessor_jni.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/SampleForTests_jni.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testMultipleJNIAdditionalImport.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testNatives.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testProxyNatives.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testProxyNativesWithNatives.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testSingleJNIAdditionalImport.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/golden/testTracing.golden
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/jni_generator.py
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/jni_generator/sample_for_tests.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/library_loader/library_loader_hooks.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/memory_pressure_listener_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/path_service_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/record_histogram.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/record_user_action.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/statistics_recorder_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/sys_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/task_scheduler/post_task_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/task_scheduler/sequenced_task_runner_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/task_scheduler/single_thread_task_runner_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/task_scheduler/task_runner_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/time_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/android/trace_event_binding.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/power_monitor/power_monitor_device_source_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/base/test/task_scheduler_test_helpers_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/after_startup_task_utils_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/browserservices/ukm_recorder.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/browsing_data/browsing_data_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/cached_image_fetcher/cached_image_fetcher_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/compositor/resources/resource_factory.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/content/content_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/contextual_suggestions/contextual_suggestions_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/cookies/cookies_fetcher_util.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/customtabs/detached_resource_request_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/download/download_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/download/items/offline_content_aggregator_factory_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/explore_sites/explore_sites_bridge_experimental.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/favicon_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feature_engagement/tracker_factory_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feedback/connectivity_checker.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feedback/process_id_feedback_source.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feedback/screenshot_task.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/feedback/system_info_feedback_source.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/foreign_session_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/headers_classifier.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/instantapps/instant_apps_settings.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/large_icon_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/locale/locale_template_url_loader.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/location_settings_impl.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/metrics/ukm_utils_for_test.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/metrics/uma_session_stats.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/metrics/uma_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/ntp/android_content_suggestions_notifier.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/ntp/recent_tabs_page_prefs.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/omnibox/answers_image_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/omnibox/query_in_omnibox_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/photo_picker_sandbox_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/policy/policy_auditor.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/preferences/website_preference_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/profiles/profile_downloader_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/profiles/profile_manager_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/rappor/rappor_service_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/rlz/revenue_stats.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/rlz/rlz_ping_handler.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/search_permissions/search_geolocation_disclosure_tab_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/service_tab_launcher.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/sessions/session_tab_helper_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/signin/account_management_screen_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/signin/account_tracker_service_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/signin/signin_investigator_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/signin/unified_consent_service_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/tab_state.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/tab_state.h
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/url_utilities.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/vr/vr_module_provider.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/warmup_manager.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/web_contents_factory.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/webapk/webapk_post_share_target_navigator.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/android/webapk/webapk_update_manager.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/autofill/android/phone_number_util_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/dom_distiller/dom_distiller_service_factory_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/dom_distiller/tab_utils_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/engagement/site_engagement_service_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/invalidation/invalidation_service_factory_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/media/android/remote/record_cast_action.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/offline_pages/android/background_scheduler_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/offline_pages/android/prefetch_configuration_impl_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/offline_pages/android/prefetch_test_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/payments/android/can_make_payment_query_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/payments/android/ssl_validity_checker_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/profiles/profile_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/profiles/profile_android.h
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/search_engines/template_url_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/signin/oauth2_token_service_delegate_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ssl/captive_portal_helper_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ssl/security_state_model_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/supervised_user/child_accounts/child_account_service_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/infobars/download_progress_infobar.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/infobars/reader_mode_infobar.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/infobars/survey_infobar.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/omnibox/omnibox_view_util.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/page_info/certificate_chain_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/page_info/certificate_viewer_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/page_info/connection_info_popup_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/page_info/page_info_controller_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/ssl_client_certificate_request.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/tab_model/single_tab_model.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/chromecast/browser/android/cast_metrics_helper_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/about_ui/credit_utils.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/cronet_test_util.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/cronet_url_request_context_config_test.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/cronet_url_request_test.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/experimental_options_test.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/mock_cert_verifier.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/mock_url_request_job_factory.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/native_test_server.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/cronet/android/test/quic_test_server.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/dom_distiller/content/browser/distillable_page_utils_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/dom_distiller/core/url_utils_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/language/android/android_language_metrics_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/language/android/geo_language_provider_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/minidump_uploader/rewrite_minidumps_as_mimes.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/payments/content/android/origin_security_checker_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/payments/content/android/payment_manifest_downloader_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/payments/content/android/payment_manifest_parser_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/payments/content/android/payment_validator_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/signin/core/browser/child_account_info_fetcher_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/sync/android/model_type_helper.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/url_formatter/url_formatter_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/components/variations/android/variations_associated_data_android.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/content/app/android/content_main.cc
[modify] https://crrev.com/c99e905516a43b083f57672a256aade7cb09b872/content/browser/android/app_web_message_port.cc
[modify] https://crrev.com/c
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e5e36ddc400fc660c72601f63739615446659a83

commit e5e36ddc400fc660c72601f63739615446659a83
Author: Artem Titarenko <artit@webrtc.org>
Date: Wed Dec 05 09:48:51 2018

Roll chromium_revision 3546854f59..2e285ebae2 (612694:613019) + fix JNI

This changelist is based on Chromium autoroller CL
https://webrtc-review.googlesource.com/c/src/+/112847
with additional JNI fixes needed to propagate upstream changes
introduced in
https://chromium.googlesource.com/chromium/src/+/c99e905516a43b083f57672a256aade7cb09b872


Change log: https://chromium.googlesource.com/chromium/src/+log/3546854f59..2e285ebae2
Full diff: https://chromium.googlesource.com/chromium/src/+/3546854f59..2e285ebae2

Changed dependencies
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/0551460b2b..62febbdbd7
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/59f4bb0792..8b1ff06550
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/0c78d113b3..2c8e8f83db
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/d387a4a97a..da3cc6c84a
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e31ab38349..a862efe9b4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1b98245e3c..6f862e54f2
* src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/016601cc21..0b287c5bca
* src/third_party/r8: uM1IGlYVeBYwmhwRCSMVqRvmu4YFlL7M2yLwZ1DWUvAC..ndmKWh0vZhDc2iLXEETOuWXVfafHbqwI_FcSgJJIfpoC
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/476768d37c..cc443eb2fd
DEPS diff: https://chromium.googlesource.com/chromium/src/+/3546854f59..2e285ebae2/DEPS

No update to Clang.

No-Try: True
Bug: chromium:898660
Change-Id: I8be89e16d9639d96fc09f053e29414381a486846
Reviewed-on: https://webrtc-review.googlesource.com/c/112595
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25900}
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/DEPS
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/examples/androidnativeapi/jni/androidcallclient.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/androidhistogram.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/androidmediadecoder.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/androidmediaencoder.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/androidmetrics.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/audio_device/java_audio_device_module.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/builtinaudiodecoderfactoryfactory.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/builtinaudioencoderfactoryfactory.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/h264utils.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/javai420buffer.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/jni_common.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/nativecapturerobserver.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/nv12buffer.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/nv21buffer.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/audiotrack.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/callsessionfilerotatinglogsink.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/dtmfsender.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/mediasource.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/mediastream.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/mediastreamtrack.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/peerconnection.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/peerconnectionfactory.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/rtccertificate.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/rtpreceiver.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/rtpsender.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/rtptransceiver.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/pc/turncustomizer.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/timestampaligner.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/videodecoderfallback.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/videoencoderfallback.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/videosource.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/videotrack.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/vp8codec.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/vp9codec.cc
[modify] https://crrev.com/e5e36ddc400fc660c72601f63739615446659a83/sdk/android/src/jni/yuvhelper.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b91d919ade43762e2577ec3c11a72de60e24fe0

commit 4b91d919ade43762e2577ec3c11a72de60e24fe0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Dec 05 15:02:24 2018

Roll src/third_party/webrtc 04744aee2f32..b819ed6df05a (4 commits)

https://webrtc.googlesource.com/src.git/+log/04744aee2f32..b819ed6df05a


git log 04744aee2f32..b819ed6df05a --date=short --no-merges --format='%ad %ae %s'
2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e285ebae2..92bac9a669 (613019:613922)
2018-12-05 solenberg@webrtc.org Reland "Remove CodecInst pt.1"
2018-12-05 hbos@webrtc.org [Unified Plan] If "a=msid" is missing, create default stream.
2018-12-05 artit@webrtc.org Roll chromium_revision 3546854f59..2e285ebae2 (612694:613019) + fix JNI


Created with:
  gclient setdep -r src/third_party/webrtc@b819ed6df05a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:907508,chromium:898660
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia79e53f78d65c77d2d2b2b5a2eab772b5c0de678
Reviewed-on: https://chromium-review.googlesource.com/c/1363234
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613965}
[modify] https://crrev.com/4b91d919ade43762e2577ec3c11a72de60e24fe0/DEPS

Labels: QuickFix

Sign in to add a comment