New issue
Advanced search Search tips

Issue 898657 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Examine Gerrit/GoB APIs to see if CL will cherry-pick cleanly.

Project Member Reported by dgarr...@chromium.org, Oct 24

Issue description

Currently the pre-cq-launcher (and the master-paladin builder) perform repo sync's then cherry-pick CLs in locally to see if the CLs will apply cleanly against a ChromeOS checkout.

This means knowing if they apply against a repo which is currently part of ChromeOS, as well as knowing if they apply cleanly.

If we could tell if they will apply cleanly via Gerrit API, they would not need to sync the general ChromeOS code (and the launcher would not need to do so in a loop).

This would help with GoB quota problems, GoB flake, and if an API solution could be found, it would be very helpful when/if we replace the pre-cq-launcher with a service.
 
Cc: jclinton@chromium.org
Cc: la...@chromium.org athilenius@chromium.org
I fully support leaning on GoB as much as we can, no need to duplicate logic. Is GoB reliable for this kind of stuff though, it seems to show 'merge conflict' pretty often. If we cannot use GoB for some reason than creating an API for this also sounds like a good idea (especially if it just commits the cherry-picked CLs to a Docker layer ;p)

Sign in to add a comment