New issue
Advanced search Search tips

Issue 898656 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Oct 25
Cc:
mccanny@chromium.org
manucornet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

No ripple when app list button is pressed with home launcher.

Project Member Reported by sammiequon@google.com, Oct 24 
What steps will reproduce the problem?
(1) Tap app list button in tablet mode.

What is the expected result?
Ripple.

What happens instead?
No ripple.

Comment 1 by newcomer@chromium.org, Oct 24

Labels: M-72
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fdfbe944835e28c45ffe29ff3b3ae363a8b1986

commit 2fdfbe944835e28c45ffe29ff3b3ae363a8b1986
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Oct 24 23:53:13 2018

shelf: Show a ripple when tapping app list button in tablet mode.

It was not shown before, probably because of Ink drop behaviour set to
ON_NO_GESTURE_HANDLER. Manually set the ink drop states when home
launcher is shown.

Test: manual
Bug:  898656 
Change-Id: Ic8fa65ae01d839d5adfeebc976bc9e744a080f2e
Reviewed-on: https://chromium-review.googlesource.com/c/1298425
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602529}
[modify] https://crrev.com/2fdfbe944835e28c45ffe29ff3b3ae363a8b1986/ash/shelf/app_list_button.cc
[modify] https://crrev.com/2fdfbe944835e28c45ffe29ff3b3ae363a8b1986/ash/shelf/shelf_view.cc
[modify] https://crrev.com/2fdfbe944835e28c45ffe29ff3b3ae363a8b1986/ash/shelf/shelf_view.h

Comment 3 by sammiequon@chromium.org, Oct 25

Status: Fixed (was: Untriaged)
►

Sign in to add a comment