Create TabUtilities to contain methods that returns Tab associated property values that can be calculated given the webstate
Create TabUtilities to contain methods that returns Tab associated UI related property values that can be calculated given the webstate
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd9327400f4e5829b2693b19f19de9dfdfe698c8 commit cd9327400f4e5829b2693b19f19de9dfdfe698c8 Author: mrefaat <mrefaat@chromium.org> Date: Thu Nov 01 16:44:35 2018 Create TabUtil and add GetTabTitle utility function to it - Create TabUtil file that will contain methods that give tab information from a given webState but are not considered a tab state property. - Delete -title from tab.h/mm and create GetTabTitle function in TabUtil - Create Unit tests for GetTabTitle / Add SetTitle to TestWebState Bug: 898655 , 898652 Change-Id: I9e30eb163d45f008e3a755cba7121526c41d5eee Reviewed-on: https://chromium-review.googlesource.com/c/1306782 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#604613} [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/tab.mm [add] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/tab_title_util.h [add] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/tab_title_util.mm [add] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/tabs/tab_title_util_unittest.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/activity_services/BUILD.gn [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/activity_services/share_to_data_builder_unittest.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/tabs/BUILD.gn [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/tabs/tab_strip_controller_unittest.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/chrome/browser/ui/tabs/tab_strip_egtest.mm [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/web/public/test/fakes/test_web_state.h [modify] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/ios/web/public/test/fakes/test_web_state.mm
Comment 1 by mrefaat@chromium.org
, Oct 25