New issue
Advanced search Search tips

Issue 898645 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WebUsbTest.NavigateWithChooserCrossOrigin

Blocking:
issue 899073



Sign in to add a comment

WebUsbTest.NavigateWithChooserCrossOrigin is flaky

Project Member Reported by Findit, Oct 24

Issue description

Cc: danakj@chromium.org
Reverted target CL, so should return to normal.
Cc: lukasza@chromium.org lfg@chromium.org
Components: Tests>Flaky Internals>Sandbox>SiteIsolation
This test has similar output to the others in https://chromium-review.googlesource.com/c/chromium/src/+/1290140 in that it's using MaybeTakeSpareRenderProcessHost, which it seems is very timing dependent. Making the renderer faster for a swapped out RenderView/Widget appears to exacerbate this.


Cc: -lfg@chromium.org reillyg@chromium.org
I'm having trouble to reproduce this flake locally with or without my CL, unlike https://bugs.chromium.org/p/chromium/issues/detail?id=888156 which was much easier to reproduce in both cases.
Labels: -Sheriff-Chromium
Removing from sheriff queue since recent build succeeded after revert.
This test does not fail by delaying the SwapOut_ACK message, unlike ProcessManagementTest.ExtensionProcessBalancing in https://bugs.chromium.org/p/chromium/issues/detail?id=898628
https://chromium-review.googlesource.com/c/chromium/src/+/1299976 suggests the sleep should make this test fail (it does there). I'll try a larger sleep.
Yes this fails locally easily with 1000ms instead of 100ms
Components: Blink>USB
Owner: danakj@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/1300421 a fix, if it is in fact the test that is a problem.
Blocking: 899073
Owner: reillyg@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1315932 fixes the underlying bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a65408413fc7b5a9b848e9e453ce50c3abf98c3

commit 0a65408413fc7b5a9b848e9e453ce50c3abf98c3
Author: Reilly Grant <reillyg@google.com>
Date: Sat Nov 03 02:54:44 2018

Close USB and Bluetooth choosers when a frame is swapped out

This change expands the set of events which trigger the WebUSB and Web
Bluetooth chooser dialogs to automatically close to include when a
RenderFrameHost is swapped out as happens on cross-origin navigation.

In this situation the dialog would already close when the RFH object
was eventually deleted. This change makes sure it happens as part of
committing the navigation.

Bug:  898645 
Change-Id: Ie35ec356687ca12d9d5ec3ee7c9d7efcb09f7f84
Reviewed-on: https://chromium-review.googlesource.com/c/1315932
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605138}
[modify] https://crrev.com/0a65408413fc7b5a9b848e9e453ce50c3abf98c3/chrome/browser/usb/usb_tab_helper.cc
[modify] https://crrev.com/0a65408413fc7b5a9b848e9e453ce50c3abf98c3/chrome/browser/usb/usb_tab_helper.h
[modify] https://crrev.com/0a65408413fc7b5a9b848e9e453ce50c3abf98c3/content/browser/frame_host/render_frame_host_impl.cc

Status: Fixed (was: Started)
Thanks!
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2faebc81dd1b73ae2f63b46e5aa02092fb533178

commit 2faebc81dd1b73ae2f63b46e5aa02092fb533178
Author: Reilly Grant <reillyg@google.com>
Date: Fri Nov 16 02:17:15 2018

Add note about frame changes to NavigationHandle::GetRenderFrameHost()

This change adds an additional note to the comment for this method
highlighting the fact that the RenderFrameHost may change during
navigation and that this method only returns the final host. To observe
the change WebContentsObserver::RenderFrameHostChanged() should be used.

Bug:  898645 
Change-Id: I716923758fae621c596b599c754e998d86324d20
Reviewed-on: https://chromium-review.googlesource.com/c/1330757
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608633}
[modify] https://crrev.com/2faebc81dd1b73ae2f63b46e5aa02092fb533178/content/public/browser/navigation_handle.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e055ffa2c157f850260ebd17537f74ccdfd7b9d3

commit e055ffa2c157f850260ebd17537f74ccdfd7b9d3
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Mon Jan 07 10:37:30 2019

Clear bluetooth service on RenderFrameHost swap.

This line was introduced by:
  https://chromium-review.googlesource.com/c/chromium/src/+/1315932
and was removed by mistake in:
  https://chromium-review.googlesource.com/c/chromium/src/+/1122629
A bad git merge is the cause of it.

Bug:  898645 
Change-Id: I2ca4d08d25974389c54263c49c2611568a7408b3
Reviewed-on: https://chromium-review.googlesource.com/c/1396397
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620285}
[modify] https://crrev.com/e055ffa2c157f850260ebd17537f74ccdfd7b9d3/content/browser/frame_host/render_frame_host_impl.cc

Sign in to add a comment