Shortcut for switching to tab 1 doesn't work on French AZERTY layout on macOS |
|||||
Issue descriptionhttps://bugs.chromium.org/p/chromium/issues/detail?id=889424#c17 I am seeing the same bug for French AZERTY layout. It used to work since forever, and stopped working a couple of weeks ago.
,
Oct 24
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0208155dec9c98a63e92c6998837ea6c48f150f5 commit 0208155dec9c98a63e92c6998837ea6c48f150f5 Author: Erik Chen <erikchen@chromium.org> Date: Thu Oct 25 19:07:48 2018 Add support for ABC-AZERTY numeric keycodes. ABC-AZERTY does not produce numerics from typical numeric keycodes, but users still expect hotkeys like cmd+'1' to work. To support this, we manually check for numeric keycodes with ABC-AZERTY. Bug: 898638 Change-Id: I71122d0d1880cdf5dff1d71ae222713f49508b1d Reviewed-on: https://chromium-review.googlesource.com/c/1299653 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602819} [modify] https://crrev.com/0208155dec9c98a63e92c6998837ea6c48f150f5/chrome/browser/ui/cocoa/nsmenuitem_additions.h [modify] https://crrev.com/0208155dec9c98a63e92c6998837ea6c48f150f5/chrome/browser/ui/cocoa/nsmenuitem_additions.mm [modify] https://crrev.com/0208155dec9c98a63e92c6998837ea6c48f150f5/chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
,
Oct 29
Fixed?
,
Oct 29
Issue 899632 has been merged into this issue.
,
Oct 30
Hi, also adding that with MacOs, the current "Jumping to Tab 3" action is CMD+MAJ+3 which is already taken by the "screenshot" action.
,
Oct 30
Issue 900199 has been merged into this issue.
,
Nov 6
,
Nov 6
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16
This is still an issue in Version 70.0.3538.102 (Official Build) (64-bit) and is killing my workflow.
,
Nov 16
The fix will be in 72.
,
Nov 20
Still an issue in Version 72.0.3616.0 (Official Build) canary (64-bit) This change is annoying me like hell, being a dev and using Chrome as one of my main tool is just a pain in the a** for 3 weeks.
,
Nov 20
This works for me on 72.0.3589.0 and 72.0.3616.0 [french ABC-AZERTY]
,
Nov 20
For me as well. kevin.schorkops@gmail.com are you using some other layout?
,
Nov 21
This is still an ultra frustrating issue, even in the latest Chrome Canary 72.0.3617.0 (on Dutch > BELGIAN keyboard setting)
,
Nov 21
kevin.schorkops@gmail.com, what layout are you using? I can reproduce this not working with both the French and the Belgian layouts on my system, 72.0.3617.0 on macOS 10.12.6 (while it works fine in Safari).
,
Nov 25
Ok so I may have found the problem : I used the "French - Numerical" for years, it allows me to use the caps lock for numbers, and it does not work neither with Chrome 70 nor Chrome 72. But with the "ABC-AZERTY" layout, it works on Version 72.0.3621.0 (Official Build) canary (64-bit), with the drawback of not having the caps lock for numbers anymore. It's better than nothing. But please fix this issue with all problematic layouts...
,
Dec 11
,
Dec 13
When will this be fixed / released? Belgians & French ppl are hitting the streets as we speak!
,
Dec 13
Heh. There's a patch in review at https://chromium-review.googlesource.com/c/chromium/src/+/1372349 , once that is in the fix should in in Canary on the next day. It'll likely be on stable in chrome 73.
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aad9192cd1ede7508716e4c9f9d5df0699d93a0e commit aad9192cd1ede7508716e4c9f9d5df0699d93a0e Author: erikchen <erikchen@chromium.org> Date: Thu Dec 13 17:17:45 2018 macOS: Make cmd+<numkey> always trigger as a numerical key. On all keyboards, treat cmd + <number key> as the equivalent numerical key. This is technically incorrect, since the actual character produced may not be a numerical key, but this causes Chrome to match the expectations of users. This mostly reverts Chrome to its historical behavior [and to match Safari], except for the Dvorak-Left and Dvorak-Right layouts, which used to have the opposite behavior. Bug: 898638 Change-Id: Ia011def220a0e6b90f080aa3259751949f3dfc5f Reviewed-on: https://chromium-review.googlesource.com/c/1372349 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#616345} [modify] https://crrev.com/aad9192cd1ede7508716e4c9f9d5df0699d93a0e/chrome/browser/ui/cocoa/nsmenuitem_additions.h [modify] https://crrev.com/aad9192cd1ede7508716e4c9f9d5df0699d93a0e/chrome/browser/ui/cocoa/nsmenuitem_additions.mm [modify] https://crrev.com/aad9192cd1ede7508716e4c9f9d5df0699d93a0e/chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by erikc...@chromium.org
, Oct 24