Clarify ImageBtimap "preserve" color space conversion mode |
|
Issue descriptionWe need to clarify what the new "preserve" color space conversion mode means for ImageBitmap. Specifically, we need to decide if "preserve" means "no precision loss" or if it means "don't touch the bytes or color profile". The current implemented behavior is "don't do any color conversion". We are also missing the serialization code for this color space conversion mode, which is already filed as crbug.com/895873.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/432a0c11b741059c17a32d1e0ebe78fcb70375ab commit 432a0c11b741059c17a32d1e0ebe78fcb70375ab Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Thu Oct 25 13:17:33 2018 Remove "preserve" color space covnersion mode from ImageBitmap interface This change list temporarily removes the "preserve" color space conversion mode from ImageBitmap interface until we know what exactly is expected from this mode. This does not remove any implementation code and this mode is still tested in unit tests. TBR=fserb@chromium.org Bug: 898631 Change-Id: I08b633a4d32204f788c5fd583f43ec16cccc0ced Reviewed-on: https://chromium-review.googlesource.com/c/1298344 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#602682} [modify] https://crrev.com/432a0c11b741059c17a32d1e0ebe78fcb70375ab/third_party/WebKit/LayoutTests/fast/canvas/color-space/transferFromImageBitmap.html [modify] https://crrev.com/432a0c11b741059c17a32d1e0ebe78fcb70375ab/third_party/blink/renderer/core/imagebitmap/image_bitmap_options.idl
,
Oct 25
Update: "preserve" mode is removed from interface and layout tests. Implementation and unit tests are still there. Whenever we knew what to do with "preserve" mode, we should revert https://chromium-review.googlesource.com/c/1298344. |
|
►
Sign in to add a comment |
|
Comment 1 by zakerinasab@chromium.org
, Oct 24