New issue
Advanced search Search tips

Issue 898627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 859152



Sign in to add a comment

RemoteMacViews: Renderers leaked when app shim process exits uncleanly

Project Member Reported by ccameron@chromium.org, Oct 24

Issue description

To reproduce, enable RemoteMacViews and PWAs
- open a PWA
- open Chrome's task manager
- kill -9 the PWA's process

Note that the renderer process for the PWA will remain until explicitly killed. This is because we don't treat the abnormal death of the PWA process as a close event from its window.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2603add1b1ef13d18c2b498a0d80aafdc5f4170

commit a2603add1b1ef13d18c2b498a0d80aafdc5f4170
Author: Christopher Cameron <ccameron@chromium.org>
Date: Wed Oct 24 21:48:38 2018

RemoteMacViews: Close window on process exit

Process death should be treated as window exit. Tested using a process
kill.

Bug:  898627 
Change-Id: I4e659dfeb71541ac2e111979842eda40110d7a66
Reviewed-on: https://chromium-review.googlesource.com/c/1298297
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602473}
[modify] https://crrev.com/a2603add1b1ef13d18c2b498a0d80aafdc5f4170/ui/views/cocoa/bridged_native_widget_host_impl.mm

Status: Fixed (was: Assigned)

Sign in to add a comment