New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

*-payloads-tryjobs fail with unknown reason

Project Member Reported by ahass...@chromium.org, Oct 24

Issue description

An example of failure with no patched CL is:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8931759279966870688

I can't really decipher what the problem is because it fails early even before hitting paygen stage.
 
Oh... the error message was surfaced super, super badly.

However, the error is this:

12:14:22: ERROR: Unkonwn build config: "edgar-payloads-tryjob"


The problem is that you need to use a version number that was generated AFTER the payloads-tryjob build configs were created.

My process, for what it's worth:

Look at it in Legoland: No error messages.
Follow the link to Milo: Clear error rendering, I'm not sure why/how.

Look for ERROR in the stage. It happened after the stage "finished" which is why it wasn't rendered correctly in Legoland.
Oh, I see, let me try again! Thanks.
Ok, This time passed green, but it didn't even tried the paygen stage? Is it because "paygen": false in crrev.com/c/1294269 ?

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8931750347306582672
Exactly right. I'll fix that.
Owner: ahass...@chromium.org
Passing over based on who can get to it first.

The config change needed is in:

config/chromeos_config.py

Update the TryjobMirrors method to not override the payloads flag to false if the build type is constants.PAYLOADS_TYPE.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0f15d306fc5b261c53ad7e9d61d6610020b6c21a

commit 0f15d306fc5b261c53ad7e9d61d6610020b6c21a
Author: Amin Hassani <ahassani@chromium.org>
Date: Tue Oct 30 15:31:09 2018

chromeos_config: Run paygen for <board>-payloads-tryjobs

payload tryjobs should be able to run paygens.

BUG= chromium:898615 
TEST=precq

Change-Id: I4673de0658a15fcfad0fdbf9da5f36314fa91c43
Reviewed-on: https://chromium-review.googlesource.com/1306376
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/0f15d306fc5b261c53ad7e9d61d6610020b6c21a/config/chromeos_config.py
[modify] https://crrev.com/0f15d306fc5b261c53ad7e9d61d6610020b6c21a/config/config_dump.json
[modify] https://crrev.com/0f15d306fc5b261c53ad7e9d61d6610020b6c21a/config/chromeos_config_unittest.py

Cc: dgarr...@chromium.org
dgarrett@ It seems the debug flag is not getting propagated correctly.
you can take a look at an example run:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930397948652656352

based on crrev.com/c/1292672

I tried to delve into the cbuildbot code base for long time but couldn't figure out what the problem is. Could it be that _RealBuilderRun is not returning attribute for debug properly (unlikely)? or maybe the cbuildbot json file for some reason does not include the debug flag? Is it supposed to? https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8930397948652656352/+/steps/cbuildbot_launch__edgar-payloads-tryjob_/0/stdout
Labels: -Pri-1 Pri-3
Status: Fixed (was: Unconfirmed)
I think the root case which was the debug flag is fixed by now. marking this as fixed!

Sign in to add a comment