New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898602 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Passing --help to browser_test_runner should show browser options

Project Member Reported by kbr@chromium.org, Oct 24

Issue description

The GPU tests use Telemetry's browser_test_runner. Currently, passing --help to these tests does not display help for Telemetry's command line arguments, only typ's. This makes it difficult for end users to understand the available browsers, as well as other options.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/bdcfce54a8d5dada227a0554771d86d704324aad

commit bdcfce54a8d5dada227a0554771d86d704324aad
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Oct 24 20:51:30 2018

Print Telemetry's help in run_browser_tests.

Rather than solely letting typ handle --help, print Telemetry's help
when returning to the calling harness.

Tbr: nednguyen@google.com
Bug:  chromium:898602 
Change-Id: I745d0d43673e2fdce7604d29bedaa61451b2cd63
Reviewed-on: https://chromium-review.googlesource.com/c/1298006
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/bdcfce54a8d5dada227a0554771d86d704324aad/telemetry/telemetry/testing/run_browser_tests.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a3db3618f0286b9350d923ca7338161fb0e044

commit 18a3db3618f0286b9350d923ca7338161fb0e044
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Oct 24 21:22:51 2018

Improve --help message for run_gpu_integration_test.

Tbr: nednguyen@google.com
No-Try: True
Bug:  898602 
Change-Id: I7da27e4ddff3ff4f15f1b56c3067ff42ecb48a05
Reviewed-on: https://chromium-review.googlesource.com/c/1298197
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602454}
[modify] https://crrev.com/18a3db3618f0286b9350d923ca7338161fb0e044/content/test/gpu/run_gpu_integration_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8cfa8af434580193da060bda78f1355ea39a963

commit a8cfa8af434580193da060bda78f1355ea39a963
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 24 22:54:11 2018

Roll src/third_party/catapult 00455e014868..bdcfce54a8d5 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/00455e014868..bdcfce54a8d5


git log 00455e014868..bdcfce54a8d5 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 kbr@chromium.org Print Telemetry's help in run_browser_tests.
2018-10-24 kjharland@google.com Whitelist Fuchsia Global integration CI builder


Created with:
  gclient setdep -r src/third_party/catapult@bdcfce54a8d5

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:898602 
TBR=sullivan@chromium.org

Change-Id: Ibcf2b7266600cb78dae90a2f90624eba5a72225d
Reviewed-on: https://chromium-review.googlesource.com/c/1298167
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602510}
[modify] https://crrev.com/a8cfa8af434580193da060bda78f1355ea39a963/DEPS

Status: Fixed (was: Started)

Sign in to add a comment